Desktop "toast" notifications display in light mode (mw.notify)
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Izno
	May 17 2024, 4:49 PM

Description

Steps to replicate the issue (include links if applicable):

Complete an edit on desktop on a dark mode page (I was able to replicate this on https://en.wikipedia.org/wiki/Draft:Sandbox )

What happens?:

What should have happened instead?: Dark background for the toast.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

AC	Status	Details
1	✅	T365280#9923839

QA Results - PROD

AC	Status	Details
1	✅	T365280#9987826

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Notifications: Migrate to Less and use design tokens	mediawiki/core	master	+12 -16

Customize query in gerrit

Related Objects

Mentioned In: T367779: Verify 1.43.0-wmf.11 deployment
T363780: [QA] Exploratory testing: Vector 2022 night theme
Mentioned Here: T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens

Event Timeline

Izno created this task.May 17 2024, 4:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 17 2024, 4:49 PM

• Mabualruz added a project: Web-Team-Backlog-Archived.May 17 2024, 5:44 PM

I'm pretty sure this is a duplicate but I can't find it right now.

Yeah, I searched also. T364117 is one about toast but it's for mobile.

Izno renamed this task from Completed edit toast displays in light mode to Completed edit toast displays as light mode.May 17 2024, 5:58 PM

T364798 is similar, but it doesn't seem to be closely related. One is using the base module JavaScript object, the other one is using OOUI?

@Esanders I think this notification comes from core or VisualEditor? Do you know where?

Jdlrobson moved this task from Backlog to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.May 21 2024, 5:21 PM

It uses mw.notify in core

Okay I found the code, it is here:
https://gerrit.wikimedia.org/g/mediawiki/core/+/658e6437a8e299e222f6546f91504f03fe2f5573/resources/src/mediawiki.action/mediawiki.action.view.postEdit.js#56

It looks like this is an OO.ui.MessageWidget inside a notification if I am not mistaken so this should be addressed by T363849

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog-Archived board.May 23 2024, 11:44 PM

Jdlrobson triaged this task as Medium priority.May 24 2024, 8:22 PM

Jdlrobson mentioned this in T363780: [QA] Exploratory testing: Vector 2022 night theme.May 31 2024, 3:52 AM

This is still an issue, and looks like a trivial issue.

Change #1042421 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Use background-color-base for notifications rather than static color

https://gerrit.wikimedia.org/r/1042421

gerritbot added a project: Patch-For-Review.Jun 12 2024, 11:54 PM

Jdlrobson renamed this task from Completed edit toast displays as light mode to Desktop notifications display in light mode.Jun 13 2024, 2:44 PM

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog-Archived.

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.Jun 13 2024, 3:54 PM

Jdlrobson renamed this task from Desktop notifications display in light mode to Desktop "toast" notifications display in light mode (mw.notify).Jun 17 2024, 8:56 PM

ovasileva raised the priority of this task from Medium to High.Jun 18 2024, 7:15 AM

Change #1042421 merged by jenkins-bot:

[mediawiki/core@master] Notifications: Migrate to Less and use design tokens

https://gerrit.wikimedia.org/r/1042421

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 20 2024, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2024, 2:32 PM

ovasileva assigned this task to GMikesell-WMF.Jun 20 2024, 5:29 PM

ovasileva lowered the priority of this task from High to Medium.

ovasileva set the point value for this task to 1.

ovasileva moved this task from Ready for estimation to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/User:Georgemikesell/sandbox
Edit and publish

2024-06-25_14-03-20.mp4.gif (540×1 px, 684 KB)

❌Separate issue @Jdlrobson Please review below that's a separate issue from this task.
https://test.wikipedia.org/wiki/User:GMikesell-WMF/sandbox
When switching to Source Editing, words are dark