Page MenuHomePhabricator

Desktop "toast" notifications display in light mode (mw.notify)
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (41×259 px, 2 KB)

What should have happened instead?: Dark background for the toast.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1T365280#9923839

Event Timeline

Jdlrobson added a subscriber: Esanders.
Jdlrobson subscribed.

I'm pretty sure this is a duplicate but I can't find it right now.

Yeah, I searched also. T364117 is one about toast but it's for mobile.

Izno renamed this task from Completed edit toast displays in light mode to Completed edit toast displays as light mode.May 17 2024, 5:58 PM

T364798 is similar, but it doesn't seem to be closely related. One is using the base module JavaScript object, the other one is using OOUI?

@Esanders I think this notification comes from core or VisualEditor? Do you know where?

Jdlrobson changed the task status from Open to Stalled.May 22 2024, 11:23 PM

Okay I found the code, it is here:
https://gerrit.wikimedia.org/g/mediawiki/core/+/658e6437a8e299e222f6546f91504f03fe2f5573/resources/src/mediawiki.action/mediawiki.action.view.postEdit.js#56

It looks like this is an OO.ui.MessageWidget inside a notification if I am not mistaken so this should be addressed by T363849

Jdlrobson triaged this task as Medium priority.May 24 2024, 8:22 PM
Jdlrobson changed the task status from Stalled to Open.Jun 12 2024, 11:53 PM

This is still an issue, and looks like a trivial issue.

Change #1042421 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Use background-color-base for notifications rather than static color

https://gerrit.wikimedia.org/r/1042421

Jdlrobson renamed this task from Completed edit toast displays as light mode to Desktop notifications display in light mode.Jun 13 2024, 2:44 PM
Jdlrobson renamed this task from Desktop notifications display in light mode to Desktop "toast" notifications display in light mode (mw.notify).Mon, Jun 17, 8:56 PM
ovasileva raised the priority of this task from Medium to High.Tue, Jun 18, 7:15 AM

Change #1042421 merged by jenkins-bot:

[mediawiki/core@master] Notifications: Migrate to Less and use design tokens

https://gerrit.wikimedia.org/r/1042421

ovasileva lowered the priority of this task from High to Medium.
ovasileva set the point value for this task to 1.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps
  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/User:Georgemikesell/sandbox
  2. Edit and publish

2024-06-25_14-03-20.mp4.gif (540×1 px, 684 KB)

❌Separate issue @Jdlrobson Please review below that's a separate issue from this task.
https://test.wikipedia.org/wiki/User:GMikesell-WMF/sandbox
When switching to Source Editing, words are dark

2024-06-25_14-08-22.mp4.gif (406×1 px, 905 KB)

When switching to Source Editing, words are dark

This is okay for the inactive state. Resolving this one, thanks @GMikesell-WMF!