Enable night mode on talk page namespaces
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 21 2024, 5:12 PM

Description

Background

Currently night theme is not available on talk namespace, due to issues with OOUI in dark mode and Flow. Since talk pages are an important part of the wiki experience night theme should be made available.

User story

AS a user I want to view talk pages in night theme.

Requirements

All subtasks resolved.
A configuration change is made to enable night theme on talk pages.

Communication criteria - does this need an announcement or discussion?

Add communication criteria

Rollback plan

We have a configuration flag for controlling rollout that can be safely modified if necessary (see wmgMinervaNightModeExcludeNamespaces)

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - Beta

AC	Status	Details
1	❌	T365509#9965955

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T367150 Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin
Resolved		ovasileva	T366738 ULS should have a dark theme
Resolved		ovasileva	T365509 Enable night mode on talk page namespaces
Open	BUG REPORT	None	T357600 Flow doesn't work in night mode
Resolved		Jdlrobson	T364777 [EPIC] Enable dark mode in OOUI
Declined	Feature	egardner	T363849 [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens
Duplicate		None	T364420 QA Editing-related night mode changes (desktop)
Resolved		ovasileva	T360691 QA Editing-related OOUI updates (mobile + desktop)
Duplicate	BUG REPORT	None	T365517 PopupWidget notification for hidden sidebars has white background
Declined	Feature	egardner	T363857 [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens
Duplicate		CCiufo-WMF	T365521 QA Editing-related REM changes
Resolved		ovasileva	T365764 [OOUI] Icons: Add support for use in dark mode
Resolved		NBaca-WMF	T366709 [Spike] Make a decision on what needs to happen for icons before the new OOUI release
Declined		Volker_E	T366101 [OOUI] Fix font size inconsistencies across skins with `rem` based sizing
Resolved		ovasileva	T366197 VisualEditor should use Codex design tokens for custom colors
Resolved	BUG REPORT	ovasileva	T367432 DiscussionTools source mode preview is not night mode friendly
Resolved		ovasileva	T366737 Vector 2022: VisualEditor toolbar and overlays should appear in night theme
Duplicate	BUG REPORT	None	T367371 VisualEditor when using CodeMirror syntax highlighting is unreadable in dark mode
Resolved	BUG REPORT	ovasileva	T367823 Many user talk page signatures are not compatible with dark mode
Resolved		ovasileva	T368086 Talk highlight doesn't work in dark mode

Event Timeline

Jdlrobson created this task.May 21 2024, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2024, 5:12 PM

Jdlrobson renamed this task from Talk pages using DiscussionTools should appear in night mode to [GOAL] Talk pages using DiscussionTools should appear in night mode.May 21 2024, 5:12 PM

Jdlrobson renamed this task from [GOAL] Talk pages using DiscussionTools should appear in night mode to [GOAL] Talk page namespace should not be excluded from night theme.

Jdlrobson added subtasks: T363857: [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens, T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens, T357600: Flow doesn't work in night mode.

Jdlrobson moved this task from Backlog to Milestones on the FY2023-24-WE 2.1 Typography and palette customizations board.May 21 2024, 5:20 PM

Jdlrobson moved this task from Milestones to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.May 21 2024, 5:23 PM

ppelberg mentioned this in T360691: QA Editing-related OOUI updates (mobile + desktop).May 22 2024, 4:23 PM

ovasileva triaged this task as High priority.May 23 2024, 9:03 AM

ovasileva moved this task from Incoming to Epics/Goals on the Web-Team-Backlog board.

CCiufo-WMF changed the status of subtask T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens from Open to Stalled.May 28 2024, 5:55 PM

CCiufo-WMF changed the status of subtask T363857: [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens from Open to Stalled.

Jdlrobson added a subtask: T364777: [EPIC] Enable dark mode in OOUI.Jun 3 2024, 10:51 PM

Jack_who_built_the_house subscribed.Jun 4 2024, 6:05 AM

Jdlrobson renamed this task from [GOAL] Talk page namespace should not be excluded from night theme to [GOAL] Talk page namespaces should not be excluded from night theme.Jun 6 2024, 2:59 PM

egardner closed subtask T363857: [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens as Declined.Jun 11 2024, 7:29 PM

egardner closed subtask T363849: [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens as Declined.

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog.Jun 13 2024, 12:13 AM

Jdlrobson added a subtask: T366197: VisualEditor should use Codex design tokens for custom colors.Jun 13 2024, 3:44 PM

Fixing VisualEditor (T366737) is a blocker for fixing discussion tools, as many of the rules we have there apply to talk pages too. Moving this out of the sprint board, as the subtasks now reflect the work involved here.

Jdlrobson added a subtask: T366737: Vector 2022: VisualEditor toolbar and overlays should appear in night theme.Jun 13 2024, 3:50 PM

ovasileva added a parent task: T366738: ULS should have a dark theme.Jun 17 2024, 12:16 PM

Jdlrobson closed subtask T364777: [EPIC] Enable dark mode in OOUI as Resolved.Jun 26 2024, 7:51 PM

Jdlrobson moved this task from Excluded experiences to Milestones on the FY2023-24-WE 2.1 Typography and palette customizations board.Jun 28 2024, 3:01 AM

ovasileva closed subtask T366737: Vector 2022: VisualEditor toolbar and overlays should appear in night theme as Resolved.Jun 28 2024, 2:17 PM

ovasileva closed subtask T367432: DiscussionTools source mode preview is not night mode friendly as Resolved.Jul 1 2024, 10:10 AM

ovasileva closed subtask T366197: VisualEditor should use Codex design tokens for custom colors as Resolved.Jul 1 2024, 10:14 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 2); removed Web-Team-Backlog.Jul 1 2024, 3:49 PM

Looks like these can now be enabled as soon as Thursday.

Jdlrobson moved this task from Needs analysis to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.Jul 1 2024, 4:45 PM

Jdlrobson assigned this task to ovasileva.Jul 1 2024, 6:11 PM

@ovasileva I am assuming T357600 is not a blocker for enabling dark mode on talk pages? If so this is ready to go! Let me know!

ovasileva closed subtask T368086: Talk highlight doesn't work in dark mode as Resolved.Jul 2 2024, 2:00 PM

Jdlrobson closed subtask T357600: Flow doesn't work in night mode as Resolved.Jul 2 2024, 3:33 PM

Jdlrobson claimed this task.Jul 2 2024, 4:16 PM

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Jdlrobson lowered the priority of this task from High to Medium.Jul 4 2024, 1:42 AM

ovasileva closed subtask T367823: Many user talk page signatures are not compatible with dark mode as Resolved.Jul 8 2024, 9:51 AM

ovasileva raised the priority of this task from Medium to High.Jul 8 2024, 10:53 AM

@Edtadros - when we're ready for QA, could you retest the bugs from the table in T360691: QA Editing-related OOUI updates (mobile + desktop) as a part of this ticket?

Done in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671 on Thursday.

Jdlrobson reassigned this task from Jdlrobson to GMikesell-WMF.Jul 8 2024, 5:15 PM

Jdlrobson moved this task from Blocked on Others to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

@Jdlrobson @ovasileva Please review below, thanks!

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

✅ Reply Tool toolbar not visible		Reply Tool (mobile)	TBD	Re-test as part of T365509
✅ Text labels within edit summary under not visible		Reply Tool (mobile)	TBD	Re-test as part of T365509
✅ New Topic Tool toolbar not visible		New Topic Tool (mobile)	TBD	Re-test as part of T365509
✅ Text labels within edit summary under not visible	{	New Topic Tool Tool (mobile)	TBD	Re-test as part of T365509
✅ Affordance for editing/reporting a topic/section not visible:		Talk pages (mobile)	TBD	Re-test as part of T365509
✅ Affordance for editing/reporting a comment not visible:		Talk pages (mobile)	TBD	Re-test as part of T365509
❓ Highlighted texts are invisible. *Mobile and Desktop highlights are different*		Discussion Tool (desktop and mobile)	web	Re-test as part of T365509
❌ Text in `<kbd />` are not visible because of the color. *Icons are still white on dekstop. Is mobile supposed to have something?*		Discussion Tool (desktop and mobile)	web	Re-test as part of T365509

❓Other Issues

Date contrast color		Desktop and Mobile
Add topic contrast color		Desktop only

GMikesell-WMF updated the task description. (Show Details)Jul 9 2024, 3:49 PM

KSarabia-WMF reassigned this task from GMikesell-WMF to Jdlrobson.Jul 9 2024, 4:10 PM

KSarabia-WMF reassigned this task from Jdlrobson to ovasileva.

KSarabia-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

KSarabia-WMF added a subscriber: GMikesell-WMF.

I'll cut some bugs and then reassign to Olga.

Jdlrobson mentioned this in T369666: OOUI progressive buttons are the wrong color in dark mode.Jul 9 2024, 8:40 PM

❓ Highlighted texts are invisible. Mobile and Desktop highlights are different

I can't replicate this. Have reached out to George for replication steps, but it also doesn't necessarily need a bug - probably a question that can be raised in the talk-to-web channel.

❌ Text in <kbd /> are not visible because of the color. Icons are still white on dekstop. Is mobile supposed to have something?

Fixed on wiki. Documented on https://www.mediawiki.org/wiki/Recommendations_for_night_mode_compatibility_on_Wikimedia_wikis#Templates_/_modules

Date contrast color

Tracked in https://phabricator.wikimedia.org/T369667.

Add topic contrast color

Tracked in https://phabricator.wikimedia.org/T369666

@Ryasmeen - we've tested all original test cases. Is there any additional testing the editing team would like to do prior to deployment?

Jdlrobson reopened subtask T357600: Flow doesn't work in night mode as Open.Jul 15 2024, 6:22 PM

ovasileva mentioned this in T367150: Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin.Jul 16 2024, 12:40 PM

Per what @ovasileva and I talked about offline during today's Editing - Web Team meeting, Editing is going to assume responsibility for testing talk pages to ensure the more targeted testing the Web Team completed in T365509#9965955 did not miss any issues.

With the above in mind, I'm moving this to the Editing QA board.

ppelberg added a subscriber: EAkinloose.Jul 16 2024, 6:24 PM

Jdlrobson removed a project: Web-Team-Backlog (FY2024-25 Q1 Sprint 1).Jul 18 2024, 7:04 PM

✅ Highlighted texts are invisible. Mobile and Desktop highlights are different

Screenshot 2024-07-27 at 05.28.10.png (746×2 px, 371 KB)

User talkTestUserEsther - Wikipedia, the free en….jpeg (2×1 px, 1 MB)

✅ Text in <kbd /> are not visible because of the color. Icons are still white on dekstop. Is mobile supposed to have something?

In T365509#9965955, @GMikesell-WMF wrote:

@Jdlrobson @ovasileva Please review below, thanks!

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

✅ Reply Tool toolbar not visible
Reply Tool (mobile) TBD Re-test as part of T365509

✅ Text labels within edit summary under not visible
Reply Tool (mobile) TBD Re-test as part of T365509

✅ New Topic Tool toolbar not visible
New Topic Tool (mobile) TBD Re-test as part of T365509

✅ Text labels within edit summary under not visible {
New Topic Tool Tool (mobile) TBD Re-test as part of T365509

✅ Affordance for editing/reporting a topic/section not visible:
Talk pages (mobile) TBD Re-test as part of T365509

✅ Affordance for editing/reporting a comment not visible:
Talk pages (mobile) TBD Re-test as part of T365509

❓ Highlighted texts are invisible. Mobile and Desktop highlights are different
Discussion Tool (desktop and mobile) web Re-test as part of T365509

❌ Text in <kbd /> are not visible because of the color. Icons are still white on dekstop. Is mobile supposed to have something?
Discussion Tool (desktop and mobile) web Re-test as part of T365509

❓Other Issues

Date contrast color
Desktop and Mobile

Add topic contrast color
Desktop only

Can this be resolved ?

Jdlrobson moved this task from Milestones to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 29 2024, 7:43 PM

In T365509#10025089, @Jdlrobson wrote:

Can this be resolved ?

With T369667 and T369666 being filed (thank you, @Jdlrobson), I think, yes.

@EAkinloose: do you agree? Are there any issues that are both NOT resolved and without Phabricator tickets?

I totally agree. We have tracking tickets already. I'll verify.

In T365509#10039738, @ppelberg wrote:

In T365509#10025089, @Jdlrobson wrote:

Can this be resolved ?

With T369667 and T369666 being filed (thank you, @Jdlrobson), I think, yes.

@EAkinloose: do you agree? Are there any issues that are both NOT resolved and without Phabricator tickets?

In T365509#10039742, @EAkinloose wrote:

I totally agree. We have tracking tickets already. I'll verify.

In T365509#10039738, @ppelberg wrote:

In T365509#10025089, @Jdlrobson wrote:

Can this be resolved ?

With T369667 and T369666 being filed (thank you, @Jdlrobson), I think, yes.

@EAkinloose: do you agree? Are there any issues that are both NOT resolved and without Phabricator tickets?

Wonderful; thank you, @EAkinloose.

@Jdlrobson: this ticket is ready for you to resolve!

	F56717953: User talkTestUserEsther - Wikipedia, the free en….jpeg
	Jul 27 2024, 4:40 AM

	F56717951: Screenshot 2024-07-27 at 05.28.10.png
	Jul 27 2024, 4:40 AM

Enable night mode on talk page namespacesClosed, ResolvedPublicActions

Description

Background

User story

Requirements

Communication criteria - does this need an announcement or discussion?

Rollback plan

QA Results - Beta

Related ObjectsSearch...

Event Timeline

Test Result - Beta

Test Result - Beta

Enable night mode on talk page namespaces
Closed, ResolvedPublic
Actions

Related Objects
Search...