Page MenuHomePhabricator

Remove usage of JsonBodyValidator from CampaignEvents
Closed, ResolvedPublic

Assigned To
Authored By
Daimona
May 21 2024, 7:55 PM
Referenced Files
F54557735: Screenshot 2024-05-28 at 2.07.25 PM.png
May 28 2024, 8:35 PM
F54560526: Screenshot 2024-05-28 at 2.48.40 PM.png
May 28 2024, 8:35 PM
F54558295: Screenshot 2024-05-28 at 2.15.36 PM.png
May 28 2024, 8:35 PM
F54563628: Screenshot 2024-05-28 at 3.34.03 PM.png
May 28 2024, 8:35 PM
F54560769: Screenshot 2024-05-28 at 2.52.05 PM.png
May 28 2024, 8:35 PM
F54558945: Screenshot 2024-05-28 at 2.24.55 PM.png
May 28 2024, 8:35 PM
F54558151: Screenshot 2024-05-28 at 2.13.47 PM.png
May 28 2024, 8:35 PM
F54554814: Screenshot 2024-05-28 at 1.22.18 PM.png
May 28 2024, 8:35 PM

Description

AC

  • REST handlers use the new validation mechanism (based on get(Body)ParamSettings) to validate the request body (see T361995).

QA notes

The following endpoint should continue to work normally:

  • Enable registration
  • Update registration
  • Cancel registration (as participant)
  • Delete registration
  • Email users
  • Register for event
  • Remove participants
  • Set organizers

I.e., no new failures, and parameters are still validated as expected (with particular attention to non-scalar parameters, things such as arrays, usernames, page titles). There is no need to test the actual actions performed by these handlers, or more generally the success states.

Event Timeline

Change #1032419 had a related patch set uploaded (by Daimona Eaytoy; author: WQuarshie):

[mediawiki/extensions/CampaignEvents@master] Use new body validation in the handlers

https://gerrit.wikimedia.org/r/1032419

Daimona removed a project: Patch-For-Review.

Patch above has been merged, but tagged with the parent task.

vaughnwalters subscribed.
✅ Enable registration✅ Update registration✅ Cancel registration (as participant)✅ Delete registration✅ Email users✅ Register for event✅ Remove participants✅ Set organizers
Screenshot 2024-05-28 at 1.22.18 PM.png (1,584×1,014 px, 172 KB)
Screenshot 2024-05-28 at 2.13.47 PM.png (1,658×1,396 px, 222 KB)
Screenshot 2024-05-28 at 2.24.55 PM.png (1,910×920 px, 165 KB)
Screenshot 2024-05-28 at 2.52.05 PM.png (1,906×926 px, 145 KB)
Screenshot 2024-05-28 at 3.34.03 PM.png (2,068×1,032 px, 186 KB)
Screenshot 2024-05-28 at 2.15.36 PM.png (1,530×1,558 px, 228 KB)
Screenshot 2024-05-28 at 2.48.40 PM.png (1,902×1,030 px, 169 KB)
Screenshot 2024-05-28 at 2.07.25 PM.png (1,616×1,248 px, 174 KB)

These are all working as expected. Marking as done / resolved.