A few things I'm not quite sure of here:

• Do we want a confirmation alert when the button is pressed?
• Should the button be hidden for some statuses, or can a wish be prepared for translation at any time? I figure that rather than using the status as an indicator of whether a wish has been prepared for translation yet, we can instead check for the existence of the subpage.
• Does it make sense to have the subpage name be Community_Wishlist/Wishes/Lorem_ipsum/Proposal? I saw somewhere that there was mention of using /Translatable as the subpage name, to make it clearer what it's for (can't find that discussion now, maybe I imagined it).

Oh right, yep: /Translatable is what we're using for Focus areas, so we should use the same for Wishes I think.

After more discussion, it sounds like we don't actually need the subpage to be created for wishes, because all discussion for them will happen on their talk pages. That means that the wish page itself can be marked for translation.

So I think the main work for for this task is to add a way to quickly add <translate> tags to the title, problem, and audience fields (i.e. the three free-text fields that are translatable). This could perhaps be a button that's visible to anyone if a wish has status=open and hasn't already been marked for translation.

We talked about the probability of having to prohibit editing via the form after a wish had been marked for translation, but this is maybe not necessary. Editing with the form after translation tags are added should work okay, except the translate tags will be visible. Is that an issue? It seems that it'd still be easier to e.g. add phab tags or change the status or whatever with the form, so there's maybe no need to avoid using the form. For example, the title field would look like:

Does this all sound correct? I'll update the task description if so.

Similar to the idea at T368349#9927714, we can have the bot set the page language on creation, then when we add the translate tags, we'll be translating to English using Extension:Translate. Fancy!

This would be dependent on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1050038

Change #1050038 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/core@master] MainConfigSchema: add 'pagelang' as a permission for 'editpage'

https://gerrit.wikimedia.org/r/1050038

Change #1050087 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Translate@master] extension.json: add translate-message permission to editpage grant

https://gerrit.wikimedia.org/r/1050087

Change #1050038 merged by jenkins-bot:

[mediawiki/core@master] MainConfigSchema: add 'pagelang' as a permission for 'editpage'

https://gerrit.wikimedia.org/r/1050038

Change #1050087 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] extension.json: add translate-message permission to editpage grant

https://gerrit.wikimedia.org/r/1050087

samwilson opened https://gitlab.wikimedia.org/toolforge-repos/wishlist-test/-/merge_requests/1

Update submodules to get recent fixes for Translate and core

samwilson merged https://gitlab.wikimedia.org/toolforge-repos/wishlist-test/-/merge_requests/1

Update submodules to get recent fixes for Translate and core

samwilson opened https://gitlab.wikimedia.org/toolforge-repos/wishlist-test/-/merge_requests/2

Grant pagelang to sysop group

samwilson merged https://gitlab.wikimedia.org/toolforge-repos/wishlist-test/-/merge_requests/2

Grant pagelang to sysop group

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/117

DeployCommand: manage aggregate message groups

samtar merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/117

DeployCommand: manage aggregate message groups

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/132

DeployCommand: add proper support for multiple gadgets

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/138

WishlistManager: new gadget for managing wishes

tstarling merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/132

DeployCommand: add proper support for multiple gadgets

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/138

WishlistManager: new gadget for managing wishes

@MusikAnimal

• Check if this is only available to staff accounts.

I can use the button even if my account has no special rights.

• Check that the button only shows on wishes that have not yet been setup for translation.

The button still appears even after a wish has had <translate> tags added and been marked for translation (e.g. https://wishlist-test.toolforge.org/wiki/Community_Wishlist/Wishes/Blocked_wish_1)

Although I see there are some that aren't, e.g. https://wishlist-test.toolforge.org/wiki/Community_Wishlist/Wishes/A_more_performant_bot_to_replace_ListeriaBot. Not sure why.

• Make sure if translation tags are applied correctly.

I tried adding translate tags to (almost) all the wishes currently on https://wishlist-test.toolforge.org. It was mostly fine.

I found a few exceptions where content after pipes was lost. Perhaps these represent wikitext proposers are unlikely to use. Examples:

• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist%2FWishes%2FWish_Title_EFGH&diff=3613&oldid=3607
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist%2FWishes%2FWish_Title_DEFG&diff=3596&oldid=3585
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist%2FWishes%2FWish_Title_CDEF&diff=3568&oldid=3563
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/Table_test_F&curid=640&diff=2990&oldid=1246
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/((Main_Page))_((colon))_(-_--_!_Header_text_--_-_Example_-)&curid=676&diff=2930&oldid=1365

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/171

WishlistManager: restrict 'Prepare for translation' to staff accounts

In T365558#9965138, @dom_walden wrote:

@MusikAnimal

• Check if this is only available to staff accounts.

I can use the button even if my account has no special rights.

Fixed with above MR (not deployed yet).

• Check that the button only shows on wishes that have not yet been setup for translation.

The button still appears even after a wish has had <translate> tags added and been marked for translation (e.g. https://wishlist-test.toolforge.org/wiki/Community_Wishlist/Wishes/Blocked_wish_1)

Although I see there are some that aren't, e.g. https://wishlist-test.toolforge.org/wiki/Community_Wishlist/Wishes/A_more_performant_bot_to_replace_ListeriaBot. Not sure why.

Could you provide repro steps? There should be a "Marked for translation" button if it has indeed been marked for translation. The script doesn't currently check for the intermediate step of there being <translate> tags but it's not marked for translation. This situation should be rare or even nonexistent though because we're going to automate the "marking" part.

• Make sure if translation tags are applied correctly.

I tried adding translate tags to (almost) all the wishes currently on https://wishlist-test.toolforge.org. It was mostly fine.

I found a few exceptions where content after pipes was lost. Perhaps these represent wikitext proposers are unlikely to use. Examples:

• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist%2FWishes%2FWish_Title_EFGH&diff=3613&oldid=3607
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist%2FWishes%2FWish_Title_DEFG&diff=3596&oldid=3585
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist%2FWishes%2FWish_Title_CDEF&diff=3568&oldid=3563
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/Table_test_F&curid=640&diff=2990&oldid=1246
• https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/((Main_Page))_((colon))_(-_--_!_Header_text_--_-_Example_-)&curid=676&diff=2930&oldid=1365

Indeed, these examples broke the syntax of the Wish template, thus we aren't able to parse it and add translate tags properly. I would not many expect wishes like this in the real-world.

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/171

WishlistManager: restrict 'Prepare for translation' to staff accounts

In T365558#9966569, @MusikAnimal wrote:

In T365558#9965138, @dom_walden wrote:

I can use the button even if my account has no special rights.

Fixed with above MR (not deployed yet).

Thanks. I checked that I don't see the button anymore as a non-admin user.

Could you provide repro steps? There should be a "Marked for translation" button if it has indeed been marked for translation. The script doesn't currently check for the intermediate step of there being <translate> tags but it's not marked for translation. This situation should be rare or even nonexistent though because we're going to automate the "marking" part.

Immediately after marking a wish for translation I still see the "Prepare for translation" button. After refreshing the page I instead see the "Marked for translation". Perhaps it is caching or bot delay.

Nevertheless, I will move this to done.