Page MenuHomePhabricator

LiquidThreads uses css clearing code that breaks overflow on the content area
Closed, ResolvedPublic

Description

LiquidThreads seams to contain the following css:
.lqt_thread_heading:after,
.lqt-thread-toolbar-commands:after,
.lqt-post-wrapper:after {

clear: both;
content: ".";
display: block;
height: 0;
visibility: hidden;

}

When the content area is given an overflow: auto; (to fix float issues or make sure that vandalism or spam can't escape the content area with absolutes) this seams to have the effect of creating extra abnormal whitespace at the end of the LQT area which results in the content area always having scrollbars, to scroll just through this small whitespace.
Essentially it has the same effect vertically as { width: 100%; border: 1px solid black; } has horizontally.

It seams that using content: ""; or omitting the content portion might work fine and doesn't suffer from this bug.


Version: unspecified
Severity: normal

Details

Reference
bz34556

Event Timeline

(In reply to comment #1)

I think the content think is not needed
https://gerrit.wikimedia.org/r/#/c/20538/

Status Merged