| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Rename admin_ng otelcol to include 'main' prefix | operations/deployment-charts | master | +12 -15 | |
| Move opentelemetry-collector to admin_ng | operations/deployment-charts | master | +33 -72 |
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T340551 distributed tracing epic | |||
| Open | None | T320549 distributed tracing v0 [minimum viable] | |||
| Open | CDanis | T363407 Proper service names in trace data | |||
| Resolved | CDanis | T365626 move k8s opentelemetry-collector from services to admin_ng | |||
| Open | None | T365809 deploy otel collector in k8s staging clusters |
Event Timeline
Comment Actions
Change #1034978 had a related patch set uploaded (by CDanis; author: CDanis):
[operations/deployment-charts@master] Move opentelemetry-collector to admin_ng
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-05-23T18:48:19Z] <cdanis> T365626 helmfile destroy'd all opentelemetry-collector releases
Comment Actions
Change #1034978 merged by jenkins-bot:
[operations/deployment-charts@master] Move opentelemetry-collector to admin_ng
Comment Actions
helmfile apply went seamlessly, but unfortunately this broke trace collection: I realized only in retrospect that this also changes the DNS name of the collector, and that's vendored into a lot of other charts with the full old name: main-opentelemetry-collector.opentelemetry-collector.svc.cluster.local
I considered an approach like an ExternalName Service as a workaround, but after finding no other extant examples in deployment-charts, then also realized that TLS usually doesn't work with such DNS aliasing approaches.
@RLazarus suggested adding an override to one of the cluster-level values.yaml files for where it's defined -- mesh.tracing.host -- but neither of us are sure how cool it is to introduce diffs of that magnitude.
I'm considering options. I might simply rename the release in the new admin_ng helmfile to main-opentelemetry-collector and decide we can live with the weird name for now.
Comment Actions
Change #1035559 had a related patch set uploaded (by CDanis; author: CDanis):
[operations/deployment-charts@master] Rename admin_ng otelcol to include 'main' prefix
Comment Actions
Change #1035559 merged by jenkins-bot:
[operations/deployment-charts@master] Rename admin_ng otelcol to include 'main' prefix