Page MenuHomePhabricator
Create Task
Maniphest T365705

ApiUploadVideoTest::testUploadVideoFiles fails in Wikibase CI (AccountCreationLogger: Error: Call to a member function getDBkey() on null)
Closed, ResolvedPublic
Actions

Description

Gate-and-submit for this change failed in three different builds in the same way:

1) ApiUploadVideoTest::testUploadVideoFiles with data set #0 (array('application/ogg', '/workspace/src/extensions/Tim...00.ogv', 301477, 400, 300, 'VIDEO', 449642, 30))
Error: Call to a member function getDBkey() on null

/workspace/src/extensions/WikimediaEvents/includes/AccountCreationLogger.php:50
/workspace/src/extensions/WikimediaEvents/includes/AccountCreationLogger.php:101
/workspace/src/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php:90
/workspace/src/includes/HookContainer/HookContainer.php:159
/workspace/src/includes/HookContainer/HookRunner.php:893
/workspace/src/includes/auth/AuthManager.php:851
/workspace/src/includes/auth/AuthManager.php:501
/workspace/src/includes/api/ApiLogin.php:178
/workspace/src/includes/api/ApiMain.php:1952
/workspace/src/includes/api/ApiMain.php:897
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:183
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiVideoUploadTestCase.php:92
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiVideoUploadTestCase.php:103
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiUploadVideoTest.php:26
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:335
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test

Show Details

2) ApiUploadVideoTest::testUploadVideoFiles with data set #1 (array('video/webm', '/workspace/src/extensions/Tim...8.webm', 699018, 1080, 608, 'VIDEO', 522142, 29.97))
Error: Call to a member function getDBkey() on null

/workspace/src/extensions/WikimediaEvents/includes/AccountCreationLogger.php:50
/workspace/src/extensions/WikimediaEvents/includes/AccountCreationLogger.php:101
/workspace/src/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php:90
/workspace/src/includes/HookContainer/HookContainer.php:159
/workspace/src/includes/HookContainer/HookRunner.php:893
/workspace/src/includes/auth/AuthManager.php:851
/workspace/src/includes/auth/AuthManager.php:501
/workspace/src/includes/api/ApiLogin.php:178
/workspace/src/includes/api/ApiMain.php:1952
/workspace/src/includes/api/ApiMain.php:897
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:183
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiVideoUploadTestCase.php:92
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiVideoUploadTestCase.php:103
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiUploadVideoTest.php:26
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:335
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test

Show Details

3) ApiUploadVideoTest::testUploadVideoFiles with data set #2 (array('audio/midi', '/workspace/src/extensions/Tim...r.midi', 262, 'AUDIO'))
Error: Call to a member function getDBkey() on null

/workspace/src/extensions/WikimediaEvents/includes/AccountCreationLogger.php:50
/workspace/src/extensions/WikimediaEvents/includes/AccountCreationLogger.php:101
/workspace/src/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php:90
/workspace/src/includes/HookContainer/HookContainer.php:159
/workspace/src/includes/HookContainer/HookRunner.php:893
/workspace/src/includes/auth/AuthManager.php:851
/workspace/src/includes/auth/AuthManager.php:501
/workspace/src/includes/api/ApiLogin.php:178
/workspace/src/includes/api/ApiMain.php:1952
/workspace/src/includes/api/ApiMain.php:897
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:183
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiVideoUploadTestCase.php:92
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiVideoUploadTestCase.php:103
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/ApiUploadVideoTest.php:26
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:335
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Tolerate missing Title in AccountCreationLoggermediawiki/extensions/WikimediaEventsmaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 23 2024, 12:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2024, 12:51 PM
Lucas_Werkmeister_WMDE added a subscriber: ArthurTaylor.May 23 2024, 12:53 PM

Neither WikimediaEvents nor TimedMediaHandler have any very recent Gerrit changes that feel like they could be related, but I think the just-merged core change Clear $wgTitle state before suite runs could be the cause? The WikimediaEvents code does look like it could end up accessing $wgTitle under the hood:

$title = RequestContext::getMain()->getTitle();
$additionalData = [
	'page_title' => $title->getDBkey(), // <!-- Error: Call to a member function getDBkey() on null
	'page_namespace' => $title->getNamespace(),
];
Lucas_Werkmeister_WMDE added a comment.May 23 2024, 1:13 PM

After enabling both extensions locally, I can reproduce the issue, and reverting “Clear $wgTitle…” does not fix it. So it’s not that after all, apparently.

• Muhammad_Yasser_Jazirahly_WMDE subscribed.May 23 2024, 1:14 PM
Lucas_Werkmeister_WMDE added a comment.May 23 2024, 1:15 PM

Reverting WikimediaEvents’ Track impressions, success and failure on the Special:CreateAccount and Special:Login pages. locally does fix the issue. (That commit is already “credited” with having caused T365403 too.)

gerritbot added a comment.May 23 2024, 1:20 PM

Change #1035423 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaEvents@master] Tolerate missing Title in AccountCreationLogger

https://gerrit.wikimedia.org/r/1035423

gerritbot added a project: Patch-For-Review.May 23 2024, 1:20 PM
Lucas_Werkmeister_WMDE added a project: [Archived]Wikidata Dev Team (Wikidata.org Slice).May 23 2024, 1:21 PM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE added a comment.May 23 2024, 1:26 PM

The timing is still strange, because “Track impressions, success…” was already merged 2 days ago whereas we’ve still had successful Wikibase merges today.

gerritbot added a comment.May 23 2024, 2:10 PM

Change #1035423 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Tolerate missing Title in AccountCreationLogger

https://gerrit.wikimedia.org/r/1035423

Maintenance_bot removed a project: Patch-For-Review.May 23 2024, 2:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 23 2024, 3:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.May 23 2024, 3:09 PM
Lucas_Werkmeister_WMDE claimed this task.

CI issue is resolved; if there was anything wrong with my fix from WikimediaEvents’ perspective, please let me know / reopen the task :)

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Nov 15 2024, 3:23 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits