Icon duplication in Vector 2022 when browser font size larger than 16
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Diskdance
	May 23 2024, 3:37 PM

Description

Steps to replicate the issue (include links if applicable):

Set browser default font size to a value larger than 16 (e.g. 18)
Open a page in Vector 2022

What happens?:

What should have happened instead?:
The icons should be displayed correctly.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.43.0-wmf.6 (5e1ad30)

Other information (browser name/version, screenshots, etc.):

Possible fix:

.vector-icon {
    background-repeat: no-repeat;
    background-position: center;
}

Derived Requirement

Ensure that icons in the Vector 2022 skin do not duplicate when the browser font size is set to a value larger than 16, and the user is logged in.

BDD

Feature: Icon Duplication in Vector 2022

  Scenario: Prevent icon duplication at larger font sizes when logged in
    Given the user is logged in
    And the user has set the browser default font size to a value larger than 16
    When the user opens a page in the Vector 2022 skin
    Then the icons should not duplicate

Test Steps

Test Case 1: Prevent Icon Duplication at Larger Font Sizes When Logged In

Log in to Wikipedia.
Set the browser default font size to a value larger than 16 (e.g., 18).
Open a page in the Vector 2022 skin.
AC1: Confirm that the icons do not duplicate.

QA Results - Beta

AC	Status	Details
1	✅	T365731#9831874

QA Results - PROD

AC	Status	Details
1	✅	T365731#9850622

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Icons should not repeat at larger font sizes	mediawiki/skins/Vector	master	+8 -0

Customize query in gerrit

Related Objects

Mentioned In: T365384: Verify 1.43.0-wmf.7 deployment
T313225: [EPIC] Various parts of MediaWiki don't respect default browser font size
Mentioned Here: rMW5e1ad3087091: Merge "docs: Remove link syntax for non-working links"

Event Timeline

Diskdance created this task.May 23 2024, 3:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2024, 3:37 PM

Jdlrobson triaged this task as High priority.May 23 2024, 4:58 PM

Jdlrobson added a project: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4).

Thanks for the clear replication steps! We will look into this shortly !

Jdlrobson updated the task description. (Show Details)May 23 2024, 5:11 PM

ovasileva set the point value for this task to 3.May 23 2024, 5:15 PM

ovasileva moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4) board.

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4) board.May 24 2024, 4:29 PM

Change #1035800 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Icons should not repeat at larger font sizes

https://gerrit.wikimedia.org/r/1035800

gerritbot added a project: Patch-For-Review.May 24 2024, 4:31 PM

@Jdrewniak can you take a look at the proposed fix?

Santropedro subscribed.May 24 2024, 6:54 PM

Jdlrobson mentioned this in T313225: [EPIC] Various parts of MediaWiki don't respect default browser font size.May 24 2024, 8:33 PM

Change #1035800 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Icons should not repeat at larger font sizes

https://gerrit.wikimedia.org/r/1035800

Jdlrobson reassigned this task from Jdrewniak to Edtadros.May 24 2024, 9:21 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 4) board.

I agree. This is very ugly and unsettling, I came redirected after a reddit post I made, they answered linking to this issue, later they deleted the post. I don't know any way to contribute to this, but I'll thank to anyone who contributes to fix this.

Santropedro unsubscribed.May 24 2024, 9:24 PM

Maintenance_bot removed a project: Patch-For-Review.May 24 2024, 9:30 PM

Jdlrobson moved this task from Incoming to Visual Enhancements / Layout on the Vector 2022 board.May 24 2024, 9:37 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 24 2024, 10:00 PM

Edtadros updated the task description. (Show Details)May 24 2024, 11:31 PM

Edtadros updated the task description. (Show Details)May 25 2024, 12:18 AM