Page MenuHomePhabricator

Remove code for sharing site/user scripts between Vector and Vector 2022 skins
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

In T331679 we gradually disabled the behaviour for Vector 2022 loading site and user scripts/styles from Vector. This is now disabled on all wikis, meaning we can remove the associated code from Vector skin. Non-functional code in a codebase is risky and creates confusion/unnecessary complication when working with the codebase, so we should remove it.

User story

As a developer I don't want code that doesn't do anything in my codebase, to make the code base easier to work with.

Requirements

Not needed.

Design

Not needed.

Acceptance criteria

  • Remove all usages of the ResourceLoaderSiteStylesModulePages and ResourceLoaderSiteModulePages hooks in MobileFrontend
  • Remove VectorResourceLoaderUserStylesModule and VectorResourceLoaderUserModule classes
  • Remove skins.vector.user and skins.vector.user.styles ResourceLoader modules
  • Remove VectorShareUserScripts configuration flag

Communication criteria - does this need an announcement or discussion?

Not needed.

Rollback plan

Not needed. This code is not doing anything.

Sign off steps

  • Clean up mediawiki config.

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1031459?usp=search

This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Change #1031456 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Vector and Vector 2022 no longer share site styles or scripts

https://gerrit.wikimedia.org/r/1031456

Jdlrobson raised the priority of this task from Medium to High.May 31 2024, 8:08 PM

Change #1031456 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector and Vector 2022 no longer share site styles or scripts

https://gerrit.wikimedia.org/r/1031456

Jdlrobson lowered the priority of this task from High to Low.Jun 4 2024, 9:21 PM

Change 1031459 added to 2024-06-11 13:00 SF backport window