| Novem_Linguae | |
| May 27 2024, 5:57 AM |
| F54434203: image.png | |
| May 27 2024, 7:07 AM |
Proposal: Consider grouping VisualEditor/VisualEditor (VisualEditor core) with "MediaWiki & services at WMF"
Rationale: Gerrit repo VisualEditor/VisualEditor (labelled "VisualEditor core" in codesearch results) is technically WMF deployed, since it is placed in the mediawiki/extensions/VisualEditor/lib/ve directory of most MediaWiki installations.
Would be nice to include this in codesearch for mass refactoring reasons.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| write_config: Add VisualEditor core to "deployed" index | labs/codesearch | master | +5 -4 |
Change #1239446 had a related patch set uploaded (by Krinkle; author: Krinkle):
[labs/codesearch@master] write_config: Add VisualEditor core to "deployed" index
The downside is that this will index the master branch of VisualEditor core and not the version currently deployed via the submodule reference of mediawiki/extensions/VisualEditor.
For similar reasons, we don't index mediawiki/libs/ under the WMF Deployed preset. Instead, we index mediawiki/vendor. See also T227704: Codesearch: "mediawiki/vendor" is missing from Everything preset.
However, unlike PHP libs, VE core is not distributed via mediawiki/vendor and also not embedded or copied into the VE extension repo. It is a git submodule, which Hound safely ignores. That's why it separately added to the "Extensions" preset, and we can safely to the same for the "WMF Deployed" preset, without causing duplication.
In terms of the version, VE core is more akin to an extension than a lib. For example, "WMF Deployed" indexes the master branch of MW extensions (not the WMF-branch), but this is fine in practice because this is updated weekly, and has the benefit of avoiding distracting results of things already fixed mid-week. Likewise, VE core is updated with a weekly pull-through (it is not on a longer release schedule, or without a schedule, like most libs are).
Change #1239446 merged by jenkins-bot:
[labs/codesearch@master] write_config: Add VisualEditor core to "deployed" index