Page MenuHomePhabricator

Deploy talk page permalinks to en.wiki
Closed, ResolvedPublic

Description

T356063: Deploy talk page permalinks to all wikis except en.wiki covered all other wikis. We were waiting for T315510: Start maintenance script to backfill talk page comment database to finish; it was reported as done on May 27.

Deployment date: Wednesday, 26 June 2024

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedDLynch
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
ResolvedPRODUCTION ERRORmatmarex
ResolvedPRODUCTION ERRORmatmarex
Resolvedmatmarex
ResolvedPRODUCTION ERRORmatmarex
ResolvedLadsgroup
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
ResolvedPRODUCTION ERRORmatmarex
Resolvedmatmarex
Resolvedmatmarex
Invalidmatmarex
ResolvedPRODUCTION ERRORmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
Resolvedmatmarex
ResolvedSecuritymatmarex

Event Timeline

Mentioned in SAL (#wikimedia-operations) [2024-05-27T14:14:11Z] <Lucas_WMDE> START lucaswerkmeister-wmde@mwmaint1002:~$ time mwscript extensions/DiscussionTools/maintenance/persistRevisionThreadItems.php --wiki enwiki --current --all --touched-after=20240524120000 2>&1 | tee -a ~/T315510-enwiki-7; date # cc T365974

It looks like User-notice was added here just because this task was forked from the parent-task which had it. Does it need another Tech News announcement? (possibly useful as a reminder for all?)

The last mention was in https://meta.wikimedia.org/wiki/Tech/News/2024/05 which used:

Starting Monday January 29, all talk pages messages' timestamps will become a link. This link is a permanent link to the comment. It allows users to find the comment they are looking for, even if this comment was moved elsewhere. This will affect all wikis except for the English Wikipedia. You can read more about this change on Diff or on Mediawiki.org. [1]

Please either help me draft a new Tech News entry, or remove the tag from here. Thanks!

The wording will be:

Starting DATE, all talk pages messages' timestamps will become a link at English Wikipedia, making this feature available at all wikis. This link is a permanent link to the comment. It allows users to find the comment they are looking for, even if this comment was moved elsewhere. You can read more about this change on Diff or on Mediawiki.org.

The wording will be:

Starting DATE, all talk pages messages' timestamps will become a link at English Wikipedia, making this feature available at all wikis. This link is a permanent link to the comment. It allows users to find the comment they are looking for, even if this comment was moved elsewhere. You can read more about this change on Diff or on Mediawiki.org.

Minor copy edit: I think it should say even if the comment is moved elsewhere in the meantime, not even if this comment was moved elsewhere: it only helps finding the comment if it’s moved after the permalink is copied; it doesn’t read the user’s mind to find the comment they think of. 🙂

Minor copy edit: I think it should say even if the comment is moved elsewhere in the meantime, not even if this comment was moved elsewhere: it only helps finding the comment if it’s moved after the permalink is copied; it doesn’t read the user’s mind to find the comment they think of. 🙂

Permalinks cover both individual comments and also section/topic titles. If a link to a topic was created as [[Pagename#Topic]], Permalinks finds it back even if the comment was moved elsewhere (like [[Pagename/Archive#Topic]]).

As suggested by a colleague, “It allows users to find the comment they were linked to, even if this comment has since been moved” would cover links to comments or to topics.

This seems deployed on the English Wikipedia; integration has been put into the Talk quote block template.

The front end is still not deployed. We will announce it when ready.

ppelberg updated the task description. (Show Details)
ppelberg subscribed.

Per offline discussion, we are scheduling the en.wiki deployment for next Wednesday, 26 June 2024 assuming @Trizek-WMF is able to post announcements about said deployment that volunteers at en.wiki are likely to see before EOD Monday, 24 June 2024.

Change #1050432 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] Enable DiscussionTools permalinks on enwiki

https://gerrit.wikimedia.org/r/1050432

Change #1050432 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable DiscussionTools permalinks on enwiki

https://gerrit.wikimedia.org/r/1050432

Mentioned in SAL (#wikimedia-operations) [2024-06-27T20:06:01Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:1050432|Enable DiscussionTools permalinks on enwiki (T365974)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-27T20:08:23Z] <jhuneidi@deploy1002> jhuneidi, kemayo: Backport for [[gerrit:1050432|Enable DiscussionTools permalinks on enwiki (T365974)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-27T20:17:11Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:1050432|Enable DiscussionTools permalinks on enwiki (T365974)]] (duration: 11m 09s)

Quick note in case QA gets to this extremely-promptly: the frontend permalinks being enabled causes a change to the cached rendered content markup. As such, the permalinks will start appearing on enwiki as page caches expire, either because of time or because edits are made to the page. (If a page doesn't have them yet, you can use action=purge and they should appear.)

EAkinloose subscribed.

Tested on en.beta(https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User_talk:TestEsther&oldid=612281)

For Tools section:

  • Permalink copied with disclaimer:

Screenshot 2024-07-15 at 17.42.26.png (268×2 px, 89 KB)

  • click event with "t-permalink.page-tools-pinned-disabled" name is emitted

For comment section:

  • Permalink copied with a popup message and the comment is highlighted:

Screenshot 2024-07-15 at 18.17.56.png (240×1 px, 29 KB)

Screenshot 2024-07-15 at 18.21.38.png (208×668 px, 19 KB)

Screenshot 2024-07-15 at 18.23.24.png (360×1 px, 89 KB)

  • click event with "discussiontools.permalink-copied" name is emitted