Page MenuHomePhabricator

Support PKCE
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
Add configuration option "codeChallengeMethod" for PKCE support. Can be set to "S256".

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
Many OIDC providers support the PKCE flow (Proof Key for Code Exchange) https://oauth.net/2/pkce/ which increases security in OIDC authentication flows. Some even mandate it.
The OpenID Connect extension should support PKCE.

Benefits (why should this be implemented?):
Increased security for OIDC authentication
Support OIDC providers with mandatory PKCE

A patch has already been submitted in Gerrit: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OpenIDConnect/+/1035869

Event Timeline

Change #1035869 had a related patch set uploaded (by Cicalese; author: Eirslett):

[mediawiki/extensions/OpenIDConnect@master] Add support for code challenge/PKCE

https://gerrit.wikimedia.org/r/1035869

Change #1035869 merged by jenkins-bot:

[mediawiki/extensions/OpenIDConnect@master] Add support for code challenge/PKCE

https://gerrit.wikimedia.org/r/1035869

Change #1110078 had a related patch set uploaded (by Cicalese; author: Eirslett):

[mediawiki/extensions/OpenIDConnect@REL1_39] Add support for code challenge/PKCE

https://gerrit.wikimedia.org/r/1110078

Change #1110079 had a related patch set uploaded (by Cicalese; author: Eirslett):

[mediawiki/extensions/OpenIDConnect@REL1_43] Add support for code challenge/PKCE

https://gerrit.wikimedia.org/r/1110079

cicalese claimed this task.

Change #1110078 merged by jenkins-bot:

[mediawiki/extensions/OpenIDConnect@REL1_39] Add support for code challenge/PKCE

https://gerrit.wikimedia.org/r/1110078

Change #1110079 merged by jenkins-bot:

[mediawiki/extensions/OpenIDConnect@REL1_43] Add support for code challenge/PKCE

https://gerrit.wikimedia.org/r/1110079