There are some scenarios where extensions (namely GE) remove the warning. For instance, GE removes it when the page is rendered for a campaign. If we change the warning to notice, should we also remove it in those situations, or on the contrary, the message can remain? @KStoller-WMF @JFernandez-WMF

@Sgs - I'm assuming in those cases there is likely other more targeted messaging on the page, so I think it makes sense to continue to remove the message when the page is rendered for a campaign. We should avoid a situation where there are multiple "competing" messages on the page.
But if you (other others) think that's an incorrect assumption, please let me know.

Change #1055918 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/MobileFrontend@master] [WIP]: Change 'Wikipedia is made by people like you' warning to a Notice message

https://gerrit.wikimedia.org/r/1055918

Change #1056119 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/core@master] LoginSignup: add support for rendering notice messages

https://gerrit.wikimedia.org/r/1056119

Change #1056120 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/skins/MinervaNeue@master] Hooks: change wikpedia is made for you warning to a notice message

https://gerrit.wikimedia.org/r/1056120

Change #1055918 abandoned by Cyndywikime:

[mediawiki/extensions/MobileFrontend@master] [WIP]: Change 'Wikipedia is made by people like you' warning to a Notice message

Reason:

Changes made in the skin(Ifa4418cbecda38011a6ee4d09c03db3ded7a9eb9) and Core (I358ee59a1a0b7a5bb94e66bca9a2437517f40141) instead

https://gerrit.wikimedia.org/r/1055918

@KStoller-WMF , @JFernandez-WMF , would it be okay to use the info icon in this case?There's no dedicated "lightbulb" icon. It is only displayed as a language variant of the cdxIconInfo in arwiki i.e it will use the lightbulb in arwiki. See docs for more information on this : https://doc.wikimedia.org/codex/v1.6.0/icons/all-icons.html. The cdxIconInfoFilled can also be an option in this case, IMO.

Ah interesting, thanks for letting me know! I'll ask DST about this though, I thought the Lightbulb icon was widely used? In the meantime, I agree using the Info icon works great. Thanks @Cyndymediawiksim 😊

Change #1056540 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] VariantHooks: change `wikipedia is made for you` warning to a notice message

https://gerrit.wikimedia.org/r/1056540

@JFernandez-WMF , @KStoller-WMF , as a reviewer suggested on this patch uploaded for this task: Hooks: change wikipedia is made for you warning to a notice message, he suggests moving this specific piece of code from the MinervaNeue skin, into MediaWiki core. Would the specific notice/warning behavior be universally beneficial across all MediaWiki use cases?

In T366127#10014214, @Cyndymediawiksim wrote:

@JFernandez-WMF , @KStoller-WMF , as a reviewer suggested on this patch uploaded for this task: Hooks: change wikipedia is made for you warning to a notice message, he suggests moving this specific piece of code from the MinervaNeue skin, into MediaWiki core. Would the specific notice/warning behavior be universally beneficial across all MediaWiki use cases?

The main user facing change is that the notice would be shown in desktop, right? cc @Jdlrobson

It would be odd to display another "Wikipedia is made by people like you" message:

I assume this is more about the Editing & Watchlist usecases mentioned here: T363035#9809479

The main user facing change is that the notice would be shown in desktop, right? cc @Jdlrobson

No. This requires the query string to work and I don't think anything in the Vector 2022 skin currently uses it, so this is more about the capability. Generally I think it's an anti-pattern to have mobile behave one way and desktop another. I believe it would be useful for future development where we want to prompt people to sign up on desktop for specific purposes. I can imagine this being useful this quarter for your work if you have sign up workflows?

@KStoller-WMF on tablet devices we already show both messages on mobile, so if it's odd, you should probably rethink this on tablet too?:

@KStoller-WMF on tablet devices we already show both messages on mobile, so if it's odd, you should probably rethink this on tablet too?:

Good point.

This task was primarily intended as a quick fix to change the styling of the message from a Warning to a Notice. As we approach the end of our sprint, let's maintain the current acceptance criteria to avoid altering the task scope significantly. However, please feel free to log additional subtasks if you identify any other small improvements that should be addressed immediately.

I believe it’s worthwhile to invest time in making further improvements, but I personally think we should wait until we can conduct logged out user testing before we consider any major changes. I have logged this task: T371128: [Epic] Special:CreateAccount experiments.

In T366127#10016690, @Jdlrobson wrote:

The main user facing change is that the notice would be shown in desktop, right? cc @Jdlrobson

No. This requires the query string to work and I don't think anything in the Vector 2022 skin currently uses it, so this is more about the capability. Generally I think it's an anti-pattern to have mobile behave one way and desktop another. I believe it would be useful for future development where we want to prompt people to sign up on desktop for specific purposes.

Gotcha.

In T366127#10018920, @KStoller-WMF wrote:

This task was primarily intended as a quick fix to change the styling of the message from a Warning to a Notice. As we approach the end of our sprint, let's maintain the current acceptance criteria to avoid altering the task scope significantly. However, please feel free to log additional subtasks if you identify any other small improvements that should be addressed immediately.

Ack.

I believe it’s worthwhile to invest time in making further improvements, but I personally think we should wait until we can conduct logged out user testing before we consider any major changes. I have logged this task: T371128: [Epic] Special:CreateAccount experiments.

I think we may want to review existing "warnings" and expand the scope of the change to notice to all of the ones we consider non-warnings.

In T366127#10022275, @Sgs wrote:

I think we may want to review existing "warnings" and expand the scope of the change to notice to all of the ones we consider non-warnings.

Agreed, I assumed that would either be completed as part of this task or in a follow-up subtask that we complete ASAP. This following is still part of this task's acceptance criteria:

Track down other places where this Warning message is being used (example for Watchlists).

In T366127#10025675, @KStoller-WMF wrote:

Agreed, I assumed that would either be completed as part of this task or in a follow-up subtask that we complete ASAP. This following is still part of this task's acceptance criteria:

Oh I had missed that. It is ambiguous if by this Warning we mean the message content or the box coloring and icon. Let me list the messages and scenarios I've found for the warning to display:

In T366127#10016690, @Jdlrobson wrote:

The main user facing change is that the notice would be shown in desktop, right? cc @Jdlrobson

No. This requires the query string to work and I don't think anything in the Vector 2022 skin currently uses it, so this is more about the capability. Generally I think it's an anti-pattern to have mobile behave one way and desktop another. I believe it would be useful for future development where we want to prompt people to sign up on desktop for specific purposes. I can imagine this being useful this quarter for your work if you have sign up workflows?

I think the capability of showing errors/warnings and notices with (1056119) would already accommodated in core. The only logic I see we could move from MinervaNeue to core are the checks for no other warning being present, user registered and was posted. Sadly that requires more work. Is it ok if we include (1), (2) & (3) in the scope of this task but leave (4) and the possible refactor to core out for now? cc @Jdlrobson @KStoller-WMF

Thank you for breaking down these other use cases!

Is it ok if we include (1), (2) & (3) in the scope of this task but leave (4) and the possible refactor to core out for now?

Yes, that makes sense to me.

Change #1056119 merged by jenkins-bot:

[mediawiki/core@master] LoginSignup: add support for rendering notice messages

https://gerrit.wikimedia.org/r/1056119

Change #1056120 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Hooks: change `wikipedia is made for you` warning to a notice message

https://gerrit.wikimedia.org/r/1056120

Change #1056540 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] VariantHooks: remove the message `wikipedia is made for you` for campaign signup

https://gerrit.wikimedia.org/r/1056540

Checked in wmf.18 - the Notice message "Wikipedia is made by people like you. Log in to contribute." is present on mobile Special:CreateAccount and Special:UserLogin pages.

enwiki	hewiki	arwiki

Summary:
(1) The message mw-createacct-benefits-container ("Wikipedia is made by people like you.") is present for Special:CreateAccount, but not for Special:UserLogin. On a tablet, those messages will be displayed side by side as it was mentioned in https://phabricator.wikimedia.org/T366127#10016690.

(2) Reviewing the use cases listed by @Sgs in https://phabricator.wikimedia.org/T366127#10028354) and documenting the current behavior in wmf.18(current production).
First case - user session expiring

• a user on a page that can be accessed only by logged in users (Special:Preferences, Special:Notificaiton, Special:Watchlist etc)
• a session expired (or a user logs out in another tab/window/device)
• a user is redirected to Special:UserLogin with the following warnings

The same warnings will be given if a non-logged user will search, for example, for Special:Watchlist.

Second case:- a non-logged user attempts to add an article to the watchlist or clicks to edit an article

• • a non-logged user clicks on the star icon (add to Watchlist icon) when reading an article**
• a user is given a prompt to log in or sign up

• clicking on the sign up option - https://en.m.wikipedia.org/w/index.php?title=Special:CreateAccount&campaign=mobile_watchPageActionCta&notice=mobile-frontend-watchlist-signup-action&returnto=Jean-Paul_Mari&returntoquery=article_action%3Dwatch

• clicking on the log in option

• a non-logged user clicks to Edit article

• clicking on the sign up option https://en.m.wikipedia.org/w/index.php?title=Special:CreateAccount&returnto=Jean-Paul_Mari%23%2Feditor%2F0&warning=mobile-frontend-edit-signup-action

• clicking on the log in option

Question - is ok to have the following as warnings?
warning=mobile-frontend-edit-signup-action
warning=mobile-frontend-edit-login-action