Maniphest T366208

Replace legacy breakpoint value tokens in web team extensions
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

DST team needs help removing legacy code. See T349793 for clear instructions on how to

User story

As as developer I only want to use the latest and greatest code.

Acceptance criteria

Replace all mentioned tokens from codebases MinervaNeue https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/972327
Replace all mentioned tokens from RelatedArticles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RelatedArticles/+/1037181)
Replace all mentioned tokens from codebase MobileFrontend
Replace all mentioned tokens from codebase Vector

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

If needed, we should aim to create a new patch to statically define the variables in the Minerva or Vector skin.

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	styles: Replace deprecated breakpoint tokens with Codex defined ones	mediawiki/extensions/MobileFrontend	master	+9 -9

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	bmartinezcalvo	T340535 [EPIC] Responsive layout approach
Open	None	T113560 Standardize MediaWiki components (tracking)
In Progress	Volker_E	T298198 [EPIC] Grid: Define a responsive column grid system in Codex
Open	None	T331403 Replace legacy value tokens in Codex, OOUI and downstream; originated in WikimediaUI Base
Resolved	Volker_E	T349793 Replace legacy breakpoint value tokens in all Wikimedia web codebases
Resolved	Jdlrobson	T366208 Replace legacy breakpoint value tokens in web team extensions

Event Timeline

Jdlrobson created this task.May 29 2024, 7:39 PM

Jdlrobson triaged this task as High priority.

Jdlrobson mentioned this in T349793: Replace legacy breakpoint value tokens in all Wikimedia web codebases.

Jdlrobson set the point value for this task to 1.

Jdlrobson moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.

Change #972327 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] styles: Replace deprecated breakpoints

https://gerrit.wikimedia.org/r/972327

gerritbot added a project: Patch-For-Review.May 29 2024, 7:41 PM

Jdlrobson updated the task description. (Show Details)May 29 2024, 7:42 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.Jun 3 2024, 6:14 PM

Per T349793#9844296 hope is to merge these tuesday (tomorrow)

Jdrewniak claimed this task.Jun 4 2024, 4:18 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.Jun 5 2024, 6:24 PM

Change #1037184 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/extensions/MobileFrontend@master] styles: Replace deprecated breakpoint tokens with Codex defined ones

https://gerrit.wikimedia.org/r/1037184

Change #1037184 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] styles: Replace deprecated breakpoint tokens with Codex defined ones

https://gerrit.wikimedia.org/r/1037184

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 7 2024, 12:00 AM

Jdlrobson mentioned this in T366860: Re-evaluate max width on Minerva.Jun 7 2024, 1:37 AM

Jdlrobson moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.Jun 7 2024, 3:03 AM

Jdlrobson updated the task description. (Show Details)Jun 10 2024, 5:21 PM

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.

@Jdlrobson to create a follow-up ticket

I created T367103. Discussing short term solutions as we speak.

After investigating this issue, and much confusion, we discovered it only impacted Monobook, and there was an issue in the original implementation of Codex carrying MediaWiki skin variables was uncovered. This ticket is therefore not blocked on this.

Jdlrobson claimed this task.Jun 10 2024, 9:50 PM

Jdlrobson added a subscriber: Jdrewniak.

Hey for completeness i've merged https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1040085?usp=search after some thorough checks, Pixel was not flagging any issues, and now we have understood and addressed https://phabricator.wikimedia.org/T367103 I see no reason not to merge this. Having a predictable state for these design tokens seems preferable than keeping Vector using the old ones, especially given our big update to OOUI/Codex tomorrow.

Seems like all this work has been worthwhile as it uncovered some existing issues with how breakpoints are used and troubles with our LESS parser. It's also led to some visual improvements in the mobile site.

Jdlrobson closed this task as Resolved.Jun 13 2024, 1:07 AM

GMikesell-WMF mentioned this in T366332: Verify 1.43.0-wmf.9 deployment.Jun 13 2024, 4:25 PM

Replace legacy breakpoint value tokens in web team extensionsClosed, ResolvedPublic1 Estimated Story PointsActions