[GENERAL] Replace usages of wgWikimediaJenkinsCI with MW_QUIBBLE_CI constant
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	May 30 2024, 8:53 AM

Description

As of rQUIBBLEa163f892ae44: Define MW_QUIBBLE_CI to replace $wgWikimediaJenkinsCI, we should check if MW_QUIBBLE_CI is defined, rather than using $wgWikimediaJenkinsCI.

Extension:EntitySchema (1 files)
- build/ci-scripts/mw-apply-wb-settings.sh (1 matches)
Extension:Wikibase (3 files)
- Wikibase.php (2 matches)
- build/ci-scripts/mw-apply-wb-settings.sh (1 matches)
- build/jenkins/mw-apply-wb-settings.sh (4 matches)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use the MW_QUIBBLE_CI constant over $wgWikimediaJenkinsCI	mediawiki/extensions/Wikibase	master	+4 -7
	Use the MW_QUIBBLE_CI constant over $wgWikimediaJenkinsCI	mediawiki/extensions/EntitySchema	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: rQUIBBLEa163f892ae44: Define MW_QUIBBLE_CI to replace $wgWikimediaJenkinsCI

Event Timeline

kostajh created this task.May 30 2024, 8:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2024, 8:53 AM

kostajh added a subscriber: hashar.May 30 2024, 8:53 AM

Maintenance_bot added a project: Wikidata.May 30 2024, 9:30 AM

ItamarWMDE renamed this task from Replace usages of wgWikimediaJenkinsCI with MW_QUIBBLE_CI constant to [GENERAL] Replace usages of wgWikimediaJenkinsCI with MW_QUIBBLE_CI constant.May 30 2024, 12:49 PM

Prio Notes:

Impact Area	Affected
production / end users	no
monitoring	no
development efforts	oui
onboarding efforts	no
additional stakeholders	ja

ItamarWMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.May 30 2024, 12:52 PM

ItamarWMDE added a project: [Archived]Wikidata Dev Team.

ItamarWMDE moved this task from [DOT] By Project to [DOT] Prioritized on the wmde-wikidata-tech board.May 30 2024, 12:54 PM

Arian_Bozorg moved this task from Incoming to [DOT] Tech Backlog on the [Archived]Wikidata Dev Team board.Jun 4 2024, 2:30 PM

karapayneWMDE moved this task from [DOT] Tech Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Jun 5 2024, 11:38 AM

hoo claimed this task.Jun 12 2024, 8:49 AM

hoo moved this task from SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) to Wikidata.org Slice on the [Archived]Wikidata Dev Team board.

hoo edited projects, added [Archived]Wikidata Dev Team (Wikidata.org Slice); removed [Archived]Wikidata Dev Team.

hoo moved this task from In Task Breakdown to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

Maintenance_bot moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Jun 12 2024, 9:29 AM

Change #1042192 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Use the MW_QUIBBLE_CI constant over $wgWikimediaJenkinsCI

https://gerrit.wikimedia.org/r/1042192

Change #1042193 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/EntitySchema@master] Use the MW_QUIBBLE_CI constant over $wgWikimediaJenkinsCI

https://gerrit.wikimedia.org/r/1042193

hoo moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Jun 12 2024, 9:57 AM

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Jun 12 2024, 10:30 AM

Change #1042192 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use the MW_QUIBBLE_CI constant over $wgWikimediaJenkinsCI

https://gerrit.wikimedia.org/r/1042192

Change #1042193 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Use the MW_QUIBBLE_CI constant over $wgWikimediaJenkinsCI

https://gerrit.wikimedia.org/r/1042193

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2024, 11:31 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Jun 12 2024, 12:00 PM

All usages have been removed. Wikibase's secondary CI passes, EntitySchema's CI didn't yet run after this was merged.

In T366243#9885019, @hoo wrote:

EntitySchema's CI didn't yet run after this was merged.

It ran now and still passes.

[GENERAL] Replace usages of wgWikimediaJenkinsCI with MW_QUIBBLE_CI constantClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[GENERAL] Replace usages of wgWikimediaJenkinsCI with MW_QUIBBLE_CI constant
Closed, ResolvedPublic
Actions