Page MenuHomePhabricator

fetch Persistent object (Z828) errors in evaluation (in test case)
Open, MediumPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: At the time of writing, five Monolingual texts are returned. These are the five elements listed in the test case’s result validation.

What should have happened instead?:

If these five elements are returned, the test case should pass, but it fails with “Error in evaluation”. If the returned elements should happen not to match, the test case should fail, but not with “Error in evaluation”

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

IMG_0950.png (2×960 px, 272 KB)
“Try this function” seems to produce the expected result.
IMG_0951.png (2×960 px, 654 KB)
The test cases actual result is a long error (possibly because the Z99K1 in K1 is an empty object, although a reference is present in the Z20)

Actual result: { "Z1K1": "Z5", "Z5K1": "Z507", "Z5K2": { "Z1K1": { "Z1K1": "Z7", "Z7K1": "Z885", "Z885K1": "Z507" }, "K1": { "Z1K1": "Z99", "Z99K1": {} }, "K2": { "Z1K1": "Z5", "Z5K1": "Z500", "Z5K2": { "Z1K1": { "Z1K1": "Z7", "Z7K1": "Z885", "Z885K1": "Z500" }, "K1": "Function call response was broken: '{ \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"Z22K2\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"K1\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z522\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z522\" }, \"K1\": \"1\", \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"K2\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"Z5K2\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"Z507K1\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"Z99K1\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"Z16556K1\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z526\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z526\" }, \"K1\": { \"Z1K1\": \"Z39\", \"Z39K1\": \"Z99K1\" }, \"K2\": { \"Z1K1\": \"Z5\", \"Z5K1\": \"Z523\", \"Z5K2\": { \"Z1K1\": { \"Z1K1\": \"Z7\", \"Z7K1\": \"Z885\", \"Z885K1\": \"Z523\" }, \"K1\": { \"Z1K1\": \"Z99\", \"Z99K1\": {} } } } } } } } } } } } } } } } } } } } }'." } } } }

As a curious aside, please note that the collapsed form of the Z20 call has its argument displayed as ‘quote("December")’ (varying by interface language) whereas the expanded form shows the quotation as "Z16112". Maybe consider something like ‘quote("Z16112"[December])’, with December linked?

Event Timeline

@GrounderUK: Assuming this task is about Wikifunctions, hence adding that project tag so other people can also find this task when searching via projects or looking at workboards. Please set appropriate project tags when possible. Thanks!

@GrounderUK: Assuming this task is about Wikifunctions, hence adding that project tag so other people can also find this task when searching via projects or looking at workboards. Please set appropriate project tags when possible. Thanks!

Thank you. I thought I had added the team but apparently not.

*https://www.wikifunctions.org/view/en/Z16573 is a test case linked directly to Z828. The failure is similar but the Z99K1 is not an empty object.

This now appears to have been fixed, thanks (and December now has 15 labels, a 200% improvement in a little over a year).

*https://www.wikifunctions.org/view/en/Z16573 is a test case linked directly to Z828. The failure is similar but the Z99K1 is not an empty object.

This still fails. But now it looks like the test is asking for object equality to test a persistent object wrapping a month to the month itself. So we can probably fix that.

Yes, I've now changed that test so that it works. I'm happy for this task to be closed. https://www.wikifunctions.org/view/en/Z16573