Error: Call to a member function getFullURL() on null
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

service.version: 1.43.0-wmf.6
trace.id: 32788454-8180-4213-b4eb-82062b3dba52
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getFullURL() on null

error.stack_trace

from /srv/mediawiki/php-1.43.0-wmf.6/extensions/MobileFrontend/includes/MobileContext.php(865)
#0 /srv/mediawiki/php-1.43.0-wmf.6/extensions/MobileFrontend/includes/MobileFrontendHooks.php(140): MobileContext->doToggling()
#1 /srv/mediawiki/php-1.43.0-wmf.6/includes/HookContainer/HookContainer.php(159): MobileFrontendHooks->onRequestContextCreateSkin(MediaWiki\Context\RequestContext, NULL)
#2 /srv/mediawiki/php-1.43.0-wmf.6/includes/HookContainer/HookRunner.php(3262): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-1.43.0-wmf.6/includes/context/RequestContext.php(576): MediaWiki\HookContainer\HookRunner->onRequestContextCreateSkin(MediaWiki\Context\RequestContext, NULL)
#4 /srv/mediawiki/php-1.43.0-wmf.6/includes/context/RequestContext.php(547): MediaWiki\Context\RequestContext->getSkinFromHook()
#5 /srv/mediawiki/php-1.43.0-wmf.6/includes/context/RequestContext.php(536): MediaWiki\Context\RequestContext->fetchSkinName()
#6 /srv/mediawiki/php-1.43.0-wmf.6/skins/Vector/includes/Hooks.php(616): MediaWiki\Context\RequestContext->getSkinName()
#7 /srv/mediawiki/php-1.43.0-wmf.6/includes/HookContainer/HookContainer.php(159): MediaWiki\Skins\Vector\Hooks->onGetBetaFeaturePreferences(MediaWiki\User\User, array)
#8 /srv/mediawiki/php-1.43.0-wmf.6/extensions/BetaFeatures/includes/Hooks/HookRunner.php(28): MediaWiki\HookContainer\HookContainer->run(string, array)
#9 /srv/mediawiki/php-1.43.0-wmf.6/extensions/BetaFeatures/includes/Hooks.php(144): MediaWiki\Extension\BetaFeatures\Hooks\HookRunner->onGetBetaFeaturePreferences(MediaWiki\User\User, array)
#10 /srv/mediawiki/php-1.43.0-wmf.6/includes/HookContainer/HookContainer.php(159): MediaWiki\Extension\BetaFeatures\Hooks->onSaveUserOptions(MediaWiki\User\User, array, array)
#11 /srv/mediawiki/php-1.43.0-wmf.6/includes/HookContainer/HookRunner.php(4404): MediaWiki\HookContainer\HookContainer->run(string, array)
#12 /srv/mediawiki/php-1.43.0-wmf.6/includes/user/Options/UserOptionsManager.php(453): MediaWiki\HookContainer\HookRunner->onSaveUserOptions(MediaWiki\User\User, array, array)
#13 /srv/mediawiki/php-1.43.0-wmf.6/includes/user/Options/UserOptionsManager.php(421): MediaWiki\User\Options\UserOptionsManager->saveOptionsInternal(MediaWiki\User\User, Wikimedia\Rdbms\DBConnRef)
#14 /srv/mediawiki/php-1.43.0-wmf.6/includes/user/User.php(2651): MediaWiki\User\Options\UserOptionsManager->saveOptions(MediaWiki\User\User)
#15 /srv/mediawiki/php-1.43.0-wmf.6/includes/auth/AuthManager.php(1967): MediaWiki\User\User->addToDatabase()
#16 /srv/mediawiki/php-1.43.0-wmf.6/includes/Setup.php(586): MediaWiki\Auth\AuthManager->autoCreateUser(MediaWiki\User\User, string, boolean)
#17 /srv/mediawiki/php-1.43.0-wmf.6/includes/WebStart.php(85): require_once(string)
#18 /srv/mediawiki/php-1.43.0-wmf.6/index.php(50): require(string)
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}

Notes

Happening across many wikis and many MediaWiki versions
All Errors coming from URLS that contain mobileaction=toggle_view_{desktop,mobile}
End of the stacktrace is similar to a very old bug T73329: MobileFrontend fatal in SpecialPage_initList hook

Details

Request URL: https://en.wikipedia.org/wiki/*?mobileaction=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Check for null from IContextSource::getTitle in MobileContext	mediawiki/extensions/MobileFrontend	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned In: T367779: Verify 1.43.0-wmf.11 deployment
Mentioned Here: T361717: [VISUAL CHANGE] Make diffs and change lists text accessible in both day and night modes
T73329: MobileFrontend fatal in SpecialPage_initList hook

Event Timeline

thcipriani created this task.May 30 2024, 3:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2024, 3:28 PM

thcipriani moved this task from Untriaged to May 2024 on the Wikimedia-production-error board.May 30 2024, 3:29 PM

Jdlrobson triaged this task as High priority.May 30 2024, 5:14 PM

Jdlrobson moved this task from Incoming to FY2023-24 Q4 Sprint 5 on the Web-Team-Backlog-Archived board.

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5); removed Web-Team-Backlog-Archived.

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.May 30 2024, 5:19 PM

Jdlrobson set the point value for this task to 2.May 30 2024, 5:28 PM

Jdlrobson moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.

SToyofuku-WMF claimed this task.Jun 4 2024, 3:59 PM

SToyofuku-WMF moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.

Lowering priority given error rate - we seem to have only 16 exceptions in last month.

@thcipriani are we correct in our understanding that this error has happened 10-20 times in the last month? Your notes seem to imply a larger volume, so I'm worried we're missing them

In T366295#9865833, @SToyofuku-WMF wrote:

@thcipriani are we correct in our understanding that this error has happened 10-20 times in the last month? Your notes seem to imply a larger volume, so I'm worried we're missing them

you're correct, it's happened 19 times over the past 30 days. I didn't mean to imply a large volume of errors, "Happening across many wikis and many MediaWiki versions" was meant to convey that this bug is:

Not a new bug in the latest code version
Not limited to a specific wiki, set of wikis, or language version

Sorry to worry you :)

Gotcha - no worries, and thank you! We are aiming to address this in the current sprint, although it will probably get worked on next week then

Also gonna take my face off this, since I'm currently working on something higher priority

I swapped this out for T361717 since they are both two points, and T361717 is more important to fix and now ready (and already estimated).

Jdlrobson edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5).Jun 14 2024, 8:58 PM

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog-Archived board.Jun 18 2024, 5:53 AM

Change #1048065 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MobileFrontend@master] Check for null from IContextSource::getTitle in MobileContext

https://gerrit.wikimedia.org/r/1048065

gerritbot added a project: Patch-For-Review.Jun 20 2024, 7:22 PM

Umherirrender claimed this task.Jun 20 2024, 7:57 PM

Change #1048065 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Check for null from IContextSource::getTitle in MobileContext

https://gerrit.wikimedia.org/r/1048065

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2024, 8:31 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 20 2024, 9:00 PM

Fix will go live 27th June. I can verify this when that's happened.

GMikesell-WMF mentioned this in T367779: Verify 1.43.0-wmf.11 deployment.Jul 3 2024, 9:37 PM

Nothing in logs: https://logstash.wikimedia.org/goto/05ec8edf17c179d39be2c41112bc24b3

Error: Call to a member function getFullURL() on nullClosed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERRORActions