Page MenuHomePhabricator

The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

The JS code that handles disabling the Locally block anonymous users only checkbox does not properly disable the checkbox if the state of the Also block the given user locally on this wiki checkbox changes to be checked and the target field is not modified from the username of an account. When the target field is modified the checkbox is properly disabled.

Steps to replicate the issue
  1. Open Special:GlobalBlock when logged into an account with the steward group and rights to locally block
  2. Enter a username into the target field
  3. Check Also block the given user locally on this wiki (or uncheck and then recheck the checkbox if it is already checked)

What happens?:
The Locally block anonymous users only checkbox is not disabled, as shown in the screenshot below.

image.png (474×952 px, 22 KB)

What should have happened instead?:
The checkbox should have been disabled.

Event Timeline

Dreamy_Jazz renamed this task from The "Locally block anonymous users only" checkbox is not disabled if is was un-hidden and the target field is not modified to The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible.Fri, May 31, 1:07 PM

Change #1037808 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Disable the local anon-only checkbox after visibility change

https://gerrit.wikimedia.org/r/1037808

Dreamy_Jazz set the point value for this task to 1.

Change #1037808 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Disable the local anon-only checkbox after visibility change

https://gerrit.wikimedia.org/r/1037808

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9757c65d08/w

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

image.png (769×1 px, 216 KB)

image.png (716×1 px, 70 KB)

image.png (887×442 px, 203 KB)

image.png (905×520 px, 197 KB)

image.png (895×699 px, 132 KB)