After T309014, Puppet will not update /etc/redis/tcp_6379.conf if it already exists, to prevent clashes with Redis Sentinel, which can modify this file.

This means that if you change or add a value in modules/profile/manifests/toolforge/redis_sentinel.pp, it will not end up in the actual config, unless you manually remove /etc/redis/tcp_6379.conf in all Redis server, and let Puppet recreate it.

I think a better option might be to create a different config file managed by Puppet, and include /that/file in /etc/redis/tcp_6379.conf.

We could do the same for /etc/redis/sentinel-toolforge.conf which also has replace => false in Puppet because it can be modified by Redis.