Page MenuHomePhabricator
Create Task
Maniphest T366367

Migrate remaining jobs off JsonSerializableObject
Closed, ResolvedPublic
Actions

Description

Using JsonSerializableObject yields some dynamic property notices. Newer jobs are just implementing Runnable. It's a pretty simple switchover and will be nice to have consistency, along with not breaking under PHP8.

Example fix: https://gerrit.wikimedia.org/r/1037819

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Event Timeline

Ejegg created this task.May 31 2024, 3:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 3:55 PM
gerritbot added a comment.May 31 2024, 3:55 PM

Change #1037819 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Switch PayPal jobs over to Runnable interface

https://gerrit.wikimedia.org/r/1037819

gerritbot added a project: Patch-For-Review.May 31 2024, 3:55 PM
Ejegg updated the task description. (Show Details)May 31 2024, 3:55 PM
• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM
JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM
XenoRyet moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Jun 3 2024, 7:51 PM
XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jun 4 2024, 7:09 PM
XenoRyet added a project: Fundraising Sprint: kevinToldMeToCallThis().Jun 4 2024, 7:18 PM
Ejegg claimed this task.Jun 6 2024, 4:25 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: kevinToldMeToCallThis() board.
gerritbot added a comment.Jun 7 2024, 2:18 AM

Change #1039897 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] WIP DownloadReportJob implements Runnable

https://gerrit.wikimedia.org/r/1039897

gerritbot added a comment.Jun 7 2024, 2:39 AM

Change #1037819 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Switch PayPal jobs over to Runnable interface

https://gerrit.wikimedia.org/r/1037819

gerritbot added a comment.Jun 18 2024, 1:49 PM

Change #1047088 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] WIP ProcessCaptureRequestJob implements Runnable

https://gerrit.wikimedia.org/r/1047088

AKanji-WMF edited projects, added: Fundraising Sprint: LeeroyJenkinsssss(); removed: Fundraising Sprint: kevinToldMeToCallThis().Jun 18 2024, 9:51 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: LeeroyJenkinsssss() board.Jun 21 2024, 4:06 PM
gerritbot added a comment.Jun 21 2024, 9:12 PM

Change #1048545 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] RecurringContractJob implements Runnable

https://gerrit.wikimedia.org/r/1048545

gerritbot added a comment.Jun 21 2024, 9:12 PM

Change #1048569 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] RecordCaptureJob implements Runnable

https://gerrit.wikimedia.org/r/1048569

gerritbot added a comment.Jun 21 2024, 9:18 PM

Change #1048570 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Delete RunnableJob abstract class

https://gerrit.wikimedia.org/r/1048570

Ejegg moved this task from Doing to Ready for Review on the Fundraising Sprint: LeeroyJenkinsssss() board.Jul 1 2024, 7:21 PM
AKanji-WMF edited projects, added: Fundraising Sprint: meow(); removed: Fundraising Sprint: LeeroyJenkinsssss().Jul 2 2024, 8:14 PM
Ejegg moved this task from Backlog to Ready for Review on the Fundraising Sprint: meow() board.Jul 2 2024, 9:01 PM
XenoRyet added a project: Fundraising Sprint: neveruse().Jul 16 2024, 7:23 PM
AnnWF moved this task from Backlog to Ready for Review on the Fundraising Sprint: neveruse() board.Jul 18 2024, 4:39 PM
jgleeson moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint: neveruse() board.Jul 19 2024, 10:13 AM
gerritbot added a comment.Jul 19 2024, 12:05 PM

Change #1039897 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] DownloadReportJob implements Runnable

https://gerrit.wikimedia.org/r/1039897

gerritbot added a comment.Jul 19 2024, 12:14 PM

Change #1047088 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] ProcessCaptureRequestJob implements Runnable

https://gerrit.wikimedia.org/r/1047088

gerritbot added a comment.Jul 20 2024, 3:02 AM

Change #1048569 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] RecordCaptureJob implements Runnable

https://gerrit.wikimedia.org/r/1048569

gerritbot added a comment.Jul 20 2024, 3:06 AM

Change #1048570 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Delete RunnableJob abstract class

https://gerrit.wikimedia.org/r/1048570

AnnWF moved this task from Being Reviewed to Pending Deployment on the Fundraising Sprint: neveruse() board.Jul 22 2024, 8:47 PM
AKanji-WMF edited projects, added: Fundraising Sprint: ogFunction(); removed: Fundraising Sprint: neveruse().Jul 30 2024, 7:37 PM
AKanji-WMF edited projects, added: Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(); removed: Fundraising Sprint: ogFunction().Aug 13 2024, 8:07 PM
AKanji-WMF removed a project: Fundraising Sprint: meow().Aug 13 2024, 8:12 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary() board.Aug 21 2024, 4:08 PM
gerritbot added a comment.Aug 21 2024, 4:47 PM

Change #1064417 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Stop using JsonSerializableObject in Autorescue test

https://gerrit.wikimedia.org/r/1064417

gerritbot added a comment.Aug 21 2024, 4:49 PM

Change #1064417 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Stop using JsonSerializableObject in Autorescue test

https://gerrit.wikimedia.org/r/1064417

gerritbot added a comment.Aug 21 2024, 5:02 PM

Change #1064422 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Remove JsonSerializableMessage from more tests

https://gerrit.wikimedia.org/r/1064422

gerritbot added a comment.Aug 21 2024, 6:53 PM

Change #1064448 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Stop calling parent::__construct() in Amazon messages

https://gerrit.wikimedia.org/r/1064448

gerritbot added a comment.Aug 22 2024, 3:46 PM

Change #1064784 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Stop using fromJson in DLocal tests

https://gerrit.wikimedia.org/r/1064784

gerritbot added a comment.Aug 22 2024, 3:46 PM

Change #1064785 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Remove JsonSerializableObject

https://gerrit.wikimedia.org/r/1064785

gerritbot added a comment.Aug 22 2024, 4:17 PM

Change #1064796 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Stop RejectedMessageJob extending JsonSerializableObject

https://gerrit.wikimedia.org/r/1064796

Ejegg moved this task from Doing to Ready for Review on the Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary() board.Aug 22 2024, 4:17 PM
AKanji-WMF edited projects, added: Fundraising Sprint: quietlyBreakingThings(); removed: Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary().Aug 27 2024, 7:43 PM
Ejegg moved this task from Backlog to Ready for Review on the Fundraising Sprint: quietlyBreakingThings() board.Aug 28 2024, 1:42 PM
gerritbot added a comment.Aug 30 2024, 12:42 AM

Change #1064422 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Remove JsonSerializableMessage from more tests

https://gerrit.wikimedia.org/r/1064422

gerritbot added a comment.Aug 30 2024, 12:42 AM

Change #1064448 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Stop calling parent::__construct() in Amazon messages

https://gerrit.wikimedia.org/r/1064448

gerritbot added a comment.Aug 30 2024, 12:42 AM

Change #1064784 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Stop using fromJson in DLocal tests

https://gerrit.wikimedia.org/r/1064784

gerritbot added a comment.Aug 30 2024, 12:43 AM

Change #1064796 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Stop RejectedMessageJob extending JsonSerializableObject

https://gerrit.wikimedia.org/r/1064796

AnnWF moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: quietlyBreakingThings() board.Aug 30 2024, 12:44 AM
gerritbot added a comment.Aug 30 2024, 12:44 AM

Change #1064785 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Remove JsonSerializableObject

https://gerrit.wikimedia.org/r/1064785

AKanji-WMF edited projects, added: Fundraising Sprint: reasonablyAccurate(); removed: Fundraising Sprint: quietlyBreakingThings().Sep 10 2024, 8:10 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint: reasonablyAccurate() board.Sep 11 2024, 8:35 PM
XenoRyet closed this task as Resolved.Sep 24 2024, 7:09 PM
XenoRyet set Final Story Points to 8.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits