Page MenuHomePhabricator
Create Task
Maniphest T366379

Special:ORESModels doesnt work in night theme
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
There are color contrast issues in the tables

What should have happened instead?:
There should not be color contrast issues

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Requirement

Ensure that Special:ORESModels is compatible with night mode, addressing color contrast issues in the tables to improve legibility.

BDD

Feature: Special:ORESModels Compatibility with Night Mode

  Scenario: Ensure color contrast is appropriate in night mode
    Given the user has enabled night mode
    When the user visits Special:ORESModels
    Then the tables should have proper color contrast
    And all elements should be legible

Test Steps

Test Case 1: Verify Special:ORESModels Compatibility with Night Mode

  1. Enable night mode.
  2. Navigate to Special:ORESModels.
  3. AC1: Confirm that the tables have proper color contrast.
  4. AC2: Confirm that all elements are legible.

QA Results - Prod

ACStatusDetails
1✅T366379#9975744
2✅T366379#9975744

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)Jdlrobsonoperations/mediawiki-configmaster+2 -21
Make Special:ORESModels compatible with night modeEbrahimmediawiki/extensions/ORESmaster+6 -5
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 31 2024, 4:42 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptMay 31 2024, 4:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.May 31 2024, 4:46 PM
Jdlrobson triaged this task as Low priority.May 31 2024, 4:49 PM
• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM
JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM
isarantopoulos moved this task from Unsorted to Watching on the Machine-Learning-Team board.Jun 4 2024, 2:22 PM
gerritbot added a comment.Jun 26 2024, 6:58 PM

Change #1050024 had a related patch set uploaded (by Ebrahim; author: Libraryupgrader):

[mediawiki/extensions/ORES@master] Make Special:ORESModels compatible with night mode

https://gerrit.wikimedia.org/r/1050024

gerritbot added a project: Patch-For-Review.Jun 26 2024, 6:58 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Needs Prioritization (Tech)).Jun 26 2024, 7:03 PM
gerritbot added a comment.Jun 26 2024, 8:59 PM

Change #1050024 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Make Special:ORESModels compatible with night mode

https://gerrit.wikimedia.org/r/1050024

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jun 26 2024, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 26 2024, 9:32 PM
gerritbot added a comment.Jun 26 2024, 11:02 PM

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

gerritbot added a project: Patch-For-Review.Jun 26 2024, 11:02 PM
gerritbot added a comment.Jun 29 2024, 2:24 AM

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2024, 2:31 AM
Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 1 2024, 11:29 PM
Jdlrobson closed this task as Resolved.Jul 2 2024, 12:57 AM
Jdlrobson claimed this task.
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1); removed: Web-Team-Backlog-Archived (Needs Prioritization (Tech)).
GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM
Edtadros updated the task description. (Show Details)Jul 12 2024, 4:01 AM
Edtadros added a project: Verified.Jul 12 2024, 4:04 AM
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Special:ORESModels Compatibility with Night Mode

  1. Enable night mode.
  2. Navigate to Special:ORESModels.
  3. ✅ AC1: Confirm that the tables have proper color contrast.

See AC2

  1. ✅ AC2: Confirm that all elements are legible.

screenshot 139.png (1,468×1,279 px, 260 KB)

Edtadros updated the task description. (Show Details)Jul 12 2024, 4:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits