Special:Hieroglyphs doesnt work in night theme
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 31 2024, 5:15 PM

Description

Steps to replicate the issue (include links if applicable):

Visit https://test.wikipedia.org/w/index.php?title=Special:Hieroglyphs

What happens?:

Images are black on black background.

What should have happened instead?:
Should be readable

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Requirement

Ensure that Special:Hieroglyphs works properly in night mode by making the images and background compatible and readable.

BDD

Feature: Compatibility of Special:Hieroglyphs with Night Mode

  Scenario: Ensure Special:Hieroglyphs is readable in night mode
    Given the user has enabled night mode
    When the user visits Special:Hieroglyphs
    Then the images should be visible
    And the background should be compatible with night mode

Test Steps

Test Case 1: Verify Special:Hieroglyphs Compatibility with Night Mode

Enable night mode.
Navigate to Special:Hieroglyphs.
AC1: Confirm that the images are visible.
AC2: Confirm that the background is compatible with night mode and the text is readable.

QA Results - Prod

AC	Status	Details
1	✅	T366384#9975750
2	✅	T366384#9975750

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)	operations/mediawiki-config	master	+2 -21
Fix Special:Hieroglyphs form compatibility with night mode	mediawiki/extensions/wikihiero	master	+1 -1
Support night theme for hieroglyphic rendering	mediawiki/extensions/wikihiero	master	+13 -12

Customize query in gerrit

Related Objects

Mentioned In: T368686: Verify 1.43.0-wmf.12 deployment
rEHIE58ccbee00557: Fix Special:Hieroglyphs form compatibility with night mode
rEHIEab3f1a6e762d: Support night theme for hieroglyphic rendering

Event Timeline

Jdlrobson created this task.May 31 2024, 5:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 5:15 PM

Jdlrobson triaged this task as Medium priority.May 31 2024, 5:17 PM

Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.

Amadalvarez subscribed.May 31 2024, 7:58 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

Change #1048843 had a related patch set uploaded (by Jdlrobson; author: Ebrahim):

[mediawiki/extensions/wikihiero@master] Support night theme

https://gerrit.wikimedia.org/r/1048843

gerritbot added a project: Patch-For-Review.Jun 25 2024, 11:17 PM

Change #1048843 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] Support night theme for hieroglyphic rendering

https://gerrit.wikimedia.org/r/1048843

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2024, 12:30 AM

Jdlrobson mentioned this in rEHIEab3f1a6e762d: Support night theme for hieroglyphic rendering.Jun 26 2024, 12:57 AM

Change #1049868 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/extensions/wikihiero@master] Fix Special:Hieroglyphs form compatibility with night mode

https://gerrit.wikimedia.org/r/1049868

gerritbot added a project: Patch-For-Review.Jun 26 2024, 9:31 AM

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

Change #1049868 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] Fix Special:Hieroglyphs form compatibility with night mode

https://gerrit.wikimedia.org/r/1049868

Ebrahim mentioned this in rEHIE58ccbee00557: Fix Special:Hieroglyphs form compatibility with night mode.Jun 26 2024, 3:56 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jun 26 2024, 4:00 PM

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2024, 2:30 AM

Jdlrobson closed this task as Resolved.Jul 1 2024, 11:28 PM

Jdlrobson claimed this task.

Jdlrobson edited projects, added Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog-Archived.

GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM

Edtadros updated the task description. (Show Details)Jul 12 2024, 4:06 AM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Special:Hieroglyphs Compatibility with Night Mode

Enable night mode.
Navigate to Special:Hieroglyphs.
✅ AC1: Confirm that the images are visible.
✅ AC2: Confirm that the background is compatible with night mode and the text is readable.