Page MenuHomePhabricator
Create Task
Maniphest T366386

Update GlobalBlockingHooks to support global account blocks
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
• Dreamy_Jazz
Authored By
• Dreamy_Jazz
May 31 2024, 6:03 PM
Tags
Referenced Files
F55416651: image.png
Jun 20 2024, 5:43 AM
F55416494: image.png
Jun 20 2024, 5:43 AM
F55416548: image.png
Jun 20 2024, 5:43 AM
F55416370: image.png
Jun 20 2024, 5:43 AM
F55416470: image.png
Jun 20 2024, 5:43 AM
F55416171: image.png
Jun 20 2024, 5:43 AM
F55416128: image.png
Jun 20 2024, 5:43 AM
F55416075: image.png
Jun 20 2024, 5:43 AM
View All 16 Files
Subscribers
Aklapper
Djackson-ctr
• Dreamy_Jazz
Johannnes89
Tchanders

Description

The GlobalBlockingHooks file needs to be updated to support global blocks on accounts, including the special contributions handler.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update GlobalBlockingHooks for global account blocksmediawiki/extensions/GlobalBlockingmaster+259 -61
Test GlobalBlockingHooksmediawiki/extensions/GlobalBlockingmaster+266 -15
Display global account blocks on Special:Contributionsmediawiki/extensions/GlobalBlockingmaster+63 -30
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 ResolvedNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 OpenNoneT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 Resolved• Dreamy_JazzT368949 [Epic] Implement global autoblocks from global user blocks
 DeclinedNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 ResolvedFeature• Dreamy_JazzT17294 Allow globally blocking of accounts
 Resolved• Dreamy_JazzT358777 Rename messages with the '-new' suffix to remove this suffix
 Resolved• Dreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 Resolved• Dreamy_JazzT358773 Remove the global accounts block configuration flag
 Resolved• Dreamy_JazzT356924 Deploy global account blocks to WMF wikis
 Resolved• Dreamy_JazzT366386 Update GlobalBlockingHooks to support global account blocks
 Resolved• Dreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 Resolved• Dreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 Resolved• Dreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 Resolved• Dreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 Resolved• Dreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 Resolved• MarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 Resolved• MarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 Resolved• Dreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 Resolved• Dreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 Resolved• Dreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 Resolved• Dreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 Resolved• Dreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 Resolved• Dreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 Resolved• Dreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 Resolved• Dreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 Resolved• Dreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 Resolved• Dreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 Resolved• Dreamy_JazzT357675 Create GlobalBlockLookup service
 Resolved• Dreamy_JazzT357925 Create the GlobalBlockManager service
 Resolved• Dreamy_JazzT366921 GlobalBlockingHooks::onSpecialPasswordResetOnSubmit is never called

Event Timeline

• Dreamy_Jazz created this task.May 31 2024, 6:03 PM
gerritbot added a comment.May 31 2024, 6:19 PM

Change #1037838 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Display global account blocks on Special:Contributions

https://gerrit.wikimedia.org/r/1037838

gerritbot added a project: Patch-For-Review.May 31 2024, 6:19 PM
• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM
JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM
• Dreamy_Jazz claimed this task.Jun 4 2024, 5:57 PM
• Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)).
• Dreamy_Jazz set the point value for this task to 2.
• Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
• Dreamy_Jazz added a subtask: T356936: Update GlobalBlocking services to support global block on accounts.
• Dreamy_Jazz moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 4 2024, 5:59 PM
gerritbot added a comment.Jun 6 2024, 6:07 PM

Change #1039803 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Test GlobalBlockingHooks

https://gerrit.wikimedia.org/r/1039803

gerritbot added a comment.Jun 7 2024, 10:21 AM

Change #1037838 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Display global account blocks on Special:Contributions

https://gerrit.wikimedia.org/r/1037838

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 7 2024, 11:00 AM
gerritbot added a comment.Jun 7 2024, 2:37 PM

Change #1040191 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update GlobalBlockingHooks for global account blocks

https://gerrit.wikimedia.org/r/1040191

• Dreamy_Jazz added a subtask: T366921: GlobalBlockingHooks::onSpecialPasswordResetOnSubmit is never called.Jun 7 2024, 4:21 PM
• Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 7 2024, 4:35 PM
• Dreamy_Jazz moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 7 2024, 4:57 PM
• Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 7 2024, 9:39 PM
gerritbot added a comment.Jun 12 2024, 10:55 AM

Change #1039803 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Test GlobalBlockingHooks

https://gerrit.wikimedia.org/r/1039803

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.10; 2024-06-18); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 12 2024, 11:00 AM
gerritbot added a comment.Jun 12 2024, 12:42 PM

Change #1040191 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockingHooks for global account blocks

https://gerrit.wikimedia.org/r/1040191

Tchanders subscribed.EditedJun 12 2024, 12:44 PM

Testing notes

This updates a few features.

Setup:

  • Set wgGlobalBlockingAllowGlobalAccountBlocks to true
  • Globally block an IP address (regression testing)
  • Globally block a user (new functionality)

Adding a block link to Special:Block and Special:BlockList:

  • On Special:Block/<globallyBlockedIp> a message should appear at the top of the page saying the user is globally blocked, with a link to details
  • Same for Special:Block/<globallyBlockedUser>, unless the blocked user is hidden and the performing user can't see hidden users
  • Same for Special:BlockList/<globallyBockedIpOrUser>
  • These should be shown even if the global block is locally disabled

Adding a notice on Special:Contributions:

  • On Special:Contributions/<globallyBlockedIp> a notice should appear at the top of the page saying the user is globally blocked
  • Same for Special:Contributions/<globallyBlockedUser>
  • These should not be shown if the global block is locally disabled

Adding links to Special:Contributions

  • On Special:Contributions/<globallyBlockedIp> the pipe-separated list of links at the top of the page should contain links for "modify the global block" and "remove the global block", which link to a form with the IP pre-filled
  • On Special:Contributions/<notGloballyBlockedIp> there should instead be a link for "global block", which links to a form with the IP pre-filled
  • Same for registered users
  • If the accessing user doesn't have the globalblock right, they shouldn't see any of these links

With wgGlobalBlockingAllowGlobalAccountBlocks false, all this should behave the same as before this task.

Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 12 2024, 12:44 PM
Johannnes89 subscribed.Jun 14 2024, 10:29 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2024, 10:30 AM
• Dreamy_Jazz closed subtask T366921: GlobalBlockingHooks::onSpecialPasswordResetOnSubmit is never called as Resolved.Jun 18 2024, 1:50 PM
Djackson-ctr subscribed.Jun 20 2024, 5:43 AM

I have verified the new code has been implemented and is functioning and displaying as expected...
Good Work @Dreamy_Jazz, and a big thank you to @Tchanders for the excellent Testing Notes which are greatly appreciated.

Screenshots for Adding a block link to Special:Block and Special:BlockList:

image.png (681×883 px, 42 KB)

image.png (767×1 px, 65 KB)

image.png (415×1 px, 38 KB)

image.png (412×1 px, 43 KB)

Screenshots for Adding a notice on Special:Contributions & Adding links to Special:Contributions:

image.png (348×884 px, 30 KB)

image.png (315×1 px, 38 KB)

image.png (289×905 px, 24 KB)

image.png (222×879 px, 18 KB)

image.png (937×922 px, 89 KB)

image.png (992×1 px, 113 KB)

image.png (349×889 px, 18 KB)

image.png (110×871 px, 12 KB)

image.png (233×916 px, 20 KB)

image.png (532×1 px, 44 KB)

image.png (588×1 px, 45 KB)

image.png (265×1 px, 30 KB)

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 20 2024, 5:51 AM
• Dreamy_Jazz closed this task as Resolved.Jun 21 2024, 1:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits