Page MenuHomePhabricator

MPIC: Add Phabricator Ticket form field
Closed, ResolvedPublic3 Estimated Story Points

Description

T360731

Description

Add the Phabricator Ticket field to all forms.

Acceptance Criteria

  • Ensure all forms can submit data for this field
  • Updates to db/api/sal work accordingly

Required

  • Unit/Integration tests?
  • Documentation?
  • Passed QA?

Artifacts & Resources

Screenshot 2024-06-03 at 12.16.30 PM.png (1×1 px, 314 KB)

Event Timeline

A couple ideas for this...

Here is an option if we just asked for a link...

Screenshot 2024-05-31 at 3.03.03 PM.png (382×1 px, 60 KB)

This seems like something that most experiments should have, are there any scenarios where this wouldn't exist hence needing to have this field be optional as shown? That would mean that if we don't have this it would need to not show up as an option in the "Action Menu" on the catalog table.

Here is an option if we asked for ticket numbers and allowed multiple tickets.

Screenshot 2024-05-31 at 3.23.28 PM.png (348×1 px, 40 KB)

I'm not sure if the number or the link is easier. I'm a bit skeptical of needing to support multiple tickets as their should be a overarching parent task and where we would link to in the action menu if there were multiple tickets?

simpler approach would definitely be the first option of just allowing one link over multiple tickets

i'm fine with that - this might be a product decision tho @VirginiaPoundstone

Oof, yeah. You touch on an interesting user behavior thing.

Some teams use one big ticket and other teams break them out into smaller parts.

Let's try "Add a link to the associated epic ticket in Phabricator." That way we will get the highest level phab task for the instrument and or experiment.

Also, this field should be required, not optional.

Seems reasonable to me, especially to start with. Here it is with updated copy and removed the optional bit.

Screenshot 2024-06-03 at 7.47.48 AM.png (364×1 px, 51 KB)

Looks great! Thank you @mwilliams.

@cjming does this give you what you need to add it to the form?

cjming triaged this task as Medium priority.

Change #1050649 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to staging

https://gerrit.wikimedia.org/r/1050649

Change #1050649 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to staging

https://gerrit.wikimedia.org/r/1050649

Change #1050656 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to production

https://gerrit.wikimedia.org/r/1050656

Change #1050656 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to production

https://gerrit.wikimedia.org/r/1050656

@VirginiaPoundstone @mwilliams just confirming that this Phabricator Ticket field should capture a full url to a phab task? not just the id i.e. T366394

we need to do validation on this field and having just the ticket number (from which we can create the phab url) is easier than validating a fully qualified url

cc @Sfaci