Page MenuHomePhabricator

TestInterwikidataBot.test_main() test of interwikidata_tests fails with TypeError
Closed, ResolvedPublic

Description

D:\pwb\GIT\core>py -3.7 -m pwb interwikidata_tests -v TestInterwikidataBot.test_main
tests: max_retries reduced from 15 to 3
test_main (__main__.TestInterwikidataBot)
Test main function interwikidata.py. ... ERROR

======================================================================
ERROR: test_main (__main__.TestInterwikidataBot)
Test main function interwikidata.py.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\pwb\GIT\core\tests\interwikidata_tests.py", line 60, in test_main
    self.assertIsNone(interwikidata.main())
  File "D:\pwb\GIT\core\scripts\interwikidata.py", line 256, in main
    bot = IWBot(generator=generator, site=site, **options)
TypeError: __init__() keywords must be strings

----------------------------------------------------------------------
Ran 1 test in 4.166s

The reason is that options dict contains {None: True} if no option is given like in pwb interwikidata

Event Timeline

Xqt triaged this task as High priority.Jun 1 2024, 4:14 PM

Change #1037892 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Do not crreate an option named None

https://gerrit.wikimedia.org/r/1037892

Change #1037892 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Do not create an option named None

https://gerrit.wikimedia.org/r/1037892