I don't see this on enwiki yet, just localhost wiki. Maybe it's because I only have one unreviewed article in my queue?

@Novem_Linguae You are correct; that's the "disabled" button when there is no next article, e.g. the end of the queue.

I interpreted the current behavior of the old toolbar code as a bug and silently "fixed" it in the new one. There's code in there that swaps the the two images around, but it always lands on the "enabled" version in the end. I don't have strong feelings about it either way. Recommend that we remove the "disabled" image when we remove the old toolbar code if we fix the "fix" in the new version.

@Novem_Linguae I wanted to follow up on this a little more explicitly: I think the old toolbar has a bug in that it does not indicate when the user has reached the end of the queue and the "next" button becomes non functional. I don't find the look of the disabled button to be particularly appealing, but there is code and an asset to support a disabled state that just doesn't happen to work in the old version of the toolbar. If the current way of showing that the button is disabled is a bug, what is the desired way to communicate it? We could also just adjust the image colors in a way that still indicates "disabled" without being such an eyesore.

If we do keep it this way, a good first step would be to change the pointer hand/finger cursor on hover back to a regular arrow cursor. In my opinion, the pointer finger cursor erroneously makes it still look clickable.

Maybe also add a "Queue empty" title= on hover.

In T366421#9871999, @Novem_Linguae wrote:

If we do keep it this way, a good first step would be to change the pointer hand/finger cursor on hover back to a regular arrow cursor. In my opinion, the pointer finger cursor erroneously makes it still look clickable.

Maybe also add a "Queue empty" title= on hover.

👍 That sounds extremely doable.

Change #1055646 had a related patch set uploaded (by Yash9265; author: Yash9265):

[mediawiki/extensions/PageTriage@master] Fix disabled state handling for next article button.

https://gerrit.wikimedia.org/r/1055646

@Novem_Linguae I have submitted a patch for this task. Please can you review it?

Looks like @Soda left a review :)

@Soda Uploaded new patch set.Please review it.

Change #1055646 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix disabled state handling for next article button.

https://gerrit.wikimedia.org/r/1055646