Page MenuHomePhabricator

Filter by patrolled-status
Open, LowestPublic

Description

Author: mmovchin

Description:
Originally reported by laaknor, Jan 1, 2009


It should be possible to filter changes by patrol-status. Wikis using
patrolling for NewPages (all Wikimedia-wikis AFAIK) and/or RecentChanges
(several Wikimedia-wikis).


Moved from the Google Code Issues Tracker (http://code.google.com/p/huggle/issues/list)


Comment 1 by ubley2286, Jan 11, 2009
feasible for queues fed from recentchanges but not arbitrary queues, as 'patrolled'
is an attribute of a recentchanges table entry, not an edit or page


Version: unspecified
Severity: enhancement

Details

Reference
bz34646

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:10 AM
bzimport added a project: Huggle.
bzimport set Reference to bz34646.
bzimport created this task.Feb 23 2012, 7:11 PM

laaknor-wmfbugzilla wrote:

Any plans to implement this?

Petrb added a comment.Dec 10 2013, 2:30 PM

Patrolling is disabled on most of WMF wikis, so this feature has really very low priority

Petrb added a comment.Jul 29 2014, 3:53 PM

how is it easily possible to check if edit is patrolled or not, can you provide me some api's for that?

https://pt.wikipedia.org/w/api.php?action=query&list=recentchanges&format=xmlfm&rcprop=patrolled&rclimit=5
returns this:
<api>

<query-continue>
  <recentchanges rccontinue="20140729163241|50125373" />
</query-continue>
<query>
  <recentchanges>
    <rc type="edit" patrolled="" />
    <rc type="edit" unpatrolled="" />
    <rc type="edit" patrolled="" />
    <rc type="edit" patrolled="" />
    <rc type="external" patrolled="" />
  </recentchanges>
</query>

</api>
and RTRC uses this:
https://github.com/Krinkle/mw-gadget-rtrc/blob/master/src/rtrc.js#L196-L197
// Convert undefined/empty-string values from API into booleans
isUnpatrolled = rc.unpatrolled !== undefined;

Petrb added a comment.Jul 29 2014, 5:57 PM

well, that is something I could implement for api based RC provider, not IRC feed. Is there a way to query this for a specific revision id?

(In reply to Peter Bena from comment #6)

well, that is something I could implement for api based RC provider, not IRC
feed. Is there a way to query this for a specific revision id?

I don't know. Maybe Krinkle knows?

Petrb added a comment.Aug 7 2014, 2:08 PM

There should be a reliable way to verify this, if there is no such, having this option in huggle would make no sense

Danilo added a comment.Aug 7 2014, 7:05 PM

I think there is not a direct way to verify the patroll status. The recentchanges table is not indexed by rc_this_oldid column, so the query "SELECT * FROM recentchanges WHERE rc_this_oldid = <some id>" is lazy, and this is probably the reason why API code don't have this option. But it can be verified based in the revision timestamp.

For example we want the patroll status for the revision 39732296, the timestamp is 20140804073720, so we make the query https://pt.wikipedia.org/w/api.php?action=query&list=recentchanges&format=xml&rcstart=20140804073720&rcprop=timestamp|ids|patrolled&rctype=new|edit&rclimit=3 and get the patrolled/unpatrolled making the code look only the row where 'revid == 39732296'.

Petrb added a comment.Aug 8 2014, 6:55 AM

that is a pretty hacky way... inserted some API people to have a look on this

Anomie added a comment.Aug 8 2014, 7:31 AM

Comment 9 appears to be correct, there currently doesn't seem to be a good way to find a particular RC entry except by timestamp.

Adding an 'rcids' parameter to list=recentchanges looks like it would be easy enough, which would let you query by rc_id if you have that.

To query by rev_id, there would first need to be an index added on rc_this_oldid.

Petrb added a comment.Aug 27 2014, 1:54 PM

until mentioned issues are resolved (make it possible to query this information using api directly) there is no point in implementing this feature to huggle as it would be extremely complicated given lack of mediawiki functionality in this area

(In reply to Peter Bena from comment #12)

lack of
mediawiki functionality in this area

There should be a blocking bug filed against MediaWiki then...

Petrb moved this task from Backlog to Need volunteer on the Huggle board.Nov 25 2014, 3:07 PM
Petrb removed Petrb as the assignee of this task.Nov 25 2014, 3:16 PM
Petrb set Security to None.
Dalba awarded a token.Jun 4 2015, 10:45 AM
Restricted Application added subscribers: Luke081515, Aklapper. · View Herald TranscriptAug 17 2015, 3:04 PM
Evs added a subscriber: Evs.Jul 13 2018, 4:38 AM