Page MenuHomePhabricator
Create Task
Maniphest T366507

Remove 'CheckUserInsertForRecentChange' hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The CheckUserInsertForRecentChangeHook has been deprecated since 1.40 and hard-deprecated since b1f12e4a5dd3a0a48f216c90c6cc7791ad68d140 (in REL1_42 and merged more than 3 months ago). As such, per the stable interface policy. it should be safe to remove the hook now.

Removing the hook is useful as it is not run for any events that are inserted into the cu_log_event or cu_private_event table. The hook can be replaced by using the any of the CheckUserInsertChangesRowHook, CheckUserInsertLogEventRowHook, and CheckUserInsertPrivateEventRowHook.

Acceptance criteria
  • Remove the hard-deprecated CheckUserInsertForRecentChange hook.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove hard-deprecated CheckUserInsertForRecentChange hookmediawiki/extensions/CheckUsermaster+0 -41
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedFeatureDreamy_JazzT324907 Create separate tables for log events in CheckUser
ResolvedDreamy_JazzT366507 Remove 'CheckUserInsertForRecentChange' hook
ResolvedDreamy_JazzT357620 Hard deprecate the CheckUserInsertForRecentChange hook
ResolvedDreamy_JazzT369539 Remove migration code from Hooks.php
· · ·

Event Timeline

Dreamy_Jazz created this task.Jun 3 2024, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2024, 4:48 PM
Dreamy_Jazz added a subtask: T357620: Hard deprecate the CheckUserInsertForRecentChange hook.Jun 5 2024, 4:44 PM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jul 10 2024, 7:40 PM
Dreamy_Jazz added a subtask: T369539: Remove migration code from Hooks.php.
Dreamy_Jazz set the point value for this task to 1.
gerritbot added a comment.Jul 10 2024, 7:56 PM

Change #1053379 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove hard-deprecated CheckUserInsertForRecentChange hook

https://gerrit.wikimedia.org/r/1053379

gerritbot added a project: Patch-For-Review.Jul 10 2024, 7:56 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 10 2024, 7:59 PM
gerritbot added a comment.Jul 11 2024, 4:51 PM

Change #1053379 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove hard-deprecated CheckUserInsertForRecentChange hook

https://gerrit.wikimedia.org/r/1053379

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 11 2024, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 11 2024, 5:30 PM
Dreamy_Jazz closed this task as Resolved.Jul 11 2024, 7:33 PM
Dreamy_Jazz updated the task description. (Show Details)
kostajh moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 12 2024, 3:33 PM
Tchanders closed subtask T369539: Remove migration code from Hooks.php as Resolved.Jul 15 2024, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits