Page MenuHomePhabricator
Create Task
Maniphest T366546

Remove wgCheckUserEventTablesMigrationStage and related migration code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Once wgCheckUserEventTablesMigrationStage has been set to SCHEMA_COMPAT_NEW, the value can be assumed to always be SCHEMA_COMPAT_NEW and the configuration value removed.

Acceptance criteria
  • Remove wgCheckUserEventTablesMigrationStage and update the code that uses it to assume that the value is SCHEMA_COMPAT_NEW
  • Remove any code paths that are now unreachable by hard-coding the value

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Jun 3 2024, 11:00 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz removed a parent task: T341830: Create maintenance script to delete entries only for read old.Jun 3 2024, 11:02 PM
Dreamy_Jazz added a subtask: T341830: Create maintenance script to delete entries only for read old.
Dreamy_Jazz added a parent task: T324907: Create separate tables for log events in CheckUser.
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint; removed Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)).Jun 4 2024, 5:30 PM
Dreamy_Jazz mentioned this in T366781: Run maintenance script to delete entries only for use when reading old on WMF wikis.Jun 6 2024, 9:36 AM
Dreamy_Jazz added a parent task: T366781: Run maintenance script to delete entries only for use when reading old on WMF wikis.
Dreamy_Jazz removed a parent task: T324907: Create separate tables for log events in CheckUser.
Dreamy_Jazz mentioned this in T366783: Remove remaining code related to event tables migration.Jun 6 2024, 9:47 AM
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Jun 6 2024, 9:50 AM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz updated the task description. (Show Details)Jun 25 2024, 3:24 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz added a subtask: T346022: Remove modifications of wgCheckUserLogAdditionalRights in code outside CheckUser.Jun 27 2024, 4:33 PM
gerritbot added a comment.Jun 27 2024, 4:37 PM

Change #1050421 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/AbuseFilter@master] Remove modification of wgCheckUserLogAdditionalRights

https://gerrit.wikimedia.org/r/1050421

gerritbot added a project: Patch-For-Review.Jun 27 2024, 4:37 PM
Dreamy_Jazz mentioned this in T346022: Remove modifications of wgCheckUserLogAdditionalRights in code outside CheckUser.Jun 27 2024, 4:45 PM
Dreamy_Jazz removed a project: Patch-For-Review.Jun 27 2024, 4:55 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)); removed Trust and Safety Product Sprint.
gerritbot added a comment.Jun 27 2024, 11:00 PM

Change #1050481 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Remove wgCheckUserEventTablesMigrationStage

https://gerrit.wikimedia.org/r/1050481

gerritbot added a project: Patch-For-Review.Jun 27 2024, 11:00 PM
Dreamy_Jazz claimed this task.Jun 28 2024, 9:38 AM
Dreamy_Jazz changed the point value for this task from 2 to 3.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
Dreamy_Jazz renamed this task from Remove wgCheckUserEventTablesMigrationStage to Remove wgCheckUserEventTablesMigrationStage and related migration code.Jun 28 2024, 10:18 AM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz removed a parent task: T366781: Run maintenance script to delete entries only for use when reading old on WMF wikis.
Dreamy_Jazz added a subtask: T366781: Run maintenance script to delete entries only for use when reading old on WMF wikis.
Dreamy_Jazz added a parent task: T366782: Remove now unused columns from cu_changes.
Dreamy_Jazz mentioned this in T324907: Create separate tables for log events in CheckUser.Jun 28 2024, 10:23 AM
kostajh closed subtask T346022: Remove modifications of wgCheckUserLogAdditionalRights in code outside CheckUser as Resolved.Jul 5 2024, 7:36 AM
gerritbot added a comment.Jul 8 2024, 10:25 AM

Change #1052694 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage in maintenance scripts

https://gerrit.wikimedia.org/r/1052694

gerritbot added a comment.Jul 8 2024, 12:36 PM

Change #1052729 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for logout handler

https://gerrit.wikimedia.org/r/1052729

gerritbot added a comment.Jul 8 2024, 1:11 PM

Change #1052735 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for login handler

https://gerrit.wikimedia.org/r/1052735

gerritbot added a comment.Jul 8 2024, 1:22 PM

Change #1052694 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage in maintenance scripts

https://gerrit.wikimedia.org/r/1052694

gerritbot added a comment.Jul 8 2024, 1:42 PM

Change #1052744 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for email handler

https://gerrit.wikimedia.org/r/1052744

gerritbot added a comment.Jul 8 2024, 1:57 PM

Change #1052747 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for reset email handler

https://gerrit.wikimedia.org/r/1052747

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 8 2024, 2:00 PM
gerritbot added a comment.Jul 8 2024, 2:38 PM

Change #1052758 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for user created handler

https://gerrit.wikimedia.org/r/1052758

gerritbot added a comment.Jul 8 2024, 5:10 PM

Change #1052787 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Remove wgCheckUserEventTablesMigrationStage for recentchange save

https://gerrit.wikimedia.org/r/1052787

gerritbot added a comment.Jul 8 2024, 5:18 PM

Change #1052788 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Move Hooks::updateCheckUserData to CheckUserInsert service

https://gerrit.wikimedia.org/r/1052788

Dreamy_Jazz updated the task description. (Show Details)Jul 8 2024, 5:36 PM
Dreamy_Jazz closed subtask T366781: Run maintenance script to delete entries only for use when reading old on WMF wikis as Resolved.Jul 9 2024, 10:40 AM
gerritbot added a comment.Jul 9 2024, 1:58 PM

Change #1052988 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage in temp account IP reveal

https://gerrit.wikimedia.org/r/1052988

gerritbot added a comment.Jul 9 2024, 1:58 PM

Change #1052989 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in CheckUser API

https://gerrit.wikimedia.org/r/1052989

gerritbot added a comment.Jul 9 2024, 1:58 PM

Change #1052990 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in autoblock handler

https://gerrit.wikimedia.org/r/1052990

gerritbot added a comment.Jul 9 2024, 1:58 PM

Change #1052991 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in Special:CheckUser

https://gerrit.wikimedia.org/r/1052991

gerritbot added a comment.Jul 9 2024, 1:58 PM

Change #1052992 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in Special:Investigate

https://gerrit.wikimedia.org/r/1052992

gerritbot added a comment.Jul 9 2024, 1:58 PM

Change #1052993 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Update comment in CheckUserLookupUtils::getIndexName

https://gerrit.wikimedia.org/r/1052993

gerritbot added a comment.Jul 9 2024, 2:01 PM

Change #1050481 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] Remove wgCheckUserEventTablesMigrationStage

Reason:

Split into smaller patches

https://gerrit.wikimedia.org/r/1050481

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 9 2024, 2:43 PM
Dreamy_Jazz moved this task from Needs Review to In Progress on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 9 2024, 3:01 PM
gerritbot added a comment.Jul 9 2024, 3:26 PM

Change #1053012 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Stop writing to cuc_actiontext in CheckUserInsert service

https://gerrit.wikimedia.org/r/1053012

gerritbot added a comment.Jul 9 2024, 3:37 PM

Change #1053014 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserEventTablesMigrationStage config

https://gerrit.wikimedia.org/r/1053014

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 9 2024, 5:04 PM
Dreamy_Jazz closed subtask T341830: Create maintenance script to delete entries only for read old as Resolved.Jul 10 2024, 9:33 AM
gerritbot added a comment.Jul 10 2024, 11:57 AM

Change #1053297 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] [CheckUser] Remove wgCheckUserEventTablesMigrationStage config

https://gerrit.wikimedia.org/r/1053297

gerritbot added a comment.Jul 11 2024, 5:17 PM

Change #1052988 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in temp account IP reveal

https://gerrit.wikimedia.org/r/1052988

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.14; 2024-07-16); removed MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 11 2024, 6:00 PM
gerritbot added a comment.Jul 12 2024, 10:02 AM

Change #1052989 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in CheckUser API

https://gerrit.wikimedia.org/r/1052989

gerritbot added a comment.Jul 12 2024, 10:45 AM

Change #1052990 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in autoblock handler

https://gerrit.wikimedia.org/r/1052990

gerritbot added a comment.Jul 12 2024, 5:22 PM

Change #1052991 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in Special:CheckUser

https://gerrit.wikimedia.org/r/1052991

gerritbot added a comment.Jul 12 2024, 5:41 PM

Change #1052992 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove event tables migration related code in Special:Investigate

https://gerrit.wikimedia.org/r/1052992

gerritbot added a comment.Jul 12 2024, 5:41 PM

Change #1052993 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update comment in CheckUserLookupUtils::getIndexName

https://gerrit.wikimedia.org/r/1052993

gerritbot added a comment.Jul 12 2024, 5:41 PM

Change #1053012 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Stop writing to cuc_actiontext in CheckUserInsert service

https://gerrit.wikimedia.org/r/1053012

gerritbot added a comment.Jul 12 2024, 6:27 PM

Change #1053974 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Remove a duplicate test case and fix an outdated doc string

https://gerrit.wikimedia.org/r/1053974

gerritbot added a comment.Jul 12 2024, 7:00 PM

Change #1053014 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserEventTablesMigrationStage config

https://gerrit.wikimedia.org/r/1053014

gerritbot added a comment.Jul 12 2024, 7:19 PM

Change #1053974 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove a duplicate test case and fix an outdated doc string

https://gerrit.wikimedia.org/r/1053974

Dreamy_Jazz updated the task description. (Show Details)Jul 12 2024, 8:24 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
Tchanders moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 14 2024, 2:00 PM
Tchanders closed this task as Resolved.Jul 15 2024, 11:03 AM
Tchanders closed subtask T369539: Remove migration code from Hooks.php as Resolved.
Dreamy_Jazz reopened this task as Open.Jul 15 2024, 3:42 PM

One config change left to do.

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)); removed Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jul 15 2024, 3:43 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
gerritbot added a comment.Jul 16 2024, 7:06 AM

Change #1053297 merged by jenkins-bot:

[operations/mediawiki-config@master] [CheckUser] Remove wgCheckUserEventTablesMigrationStage config

https://gerrit.wikimedia.org/r/1053297

Stashbot added a comment.Jul 16 2024, 7:07 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-16T07:07:43Z] <dreamyjazz@deploy1002> Started scap sync-world: Backport for [[gerrit:1053297|[CheckUser] Remove wgCheckUserEventTablesMigrationStage config (T366546)]]

Stashbot added a comment.Jul 16 2024, 7:14 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-16T07:14:48Z] <dreamyjazz@deploy1002> dreamyjazz: Backport for [[gerrit:1053297|[CheckUser] Remove wgCheckUserEventTablesMigrationStage config (T366546)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jul 16 2024, 7:19 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-16T07:19:52Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1053297|[CheckUser] Remove wgCheckUserEventTablesMigrationStage config (T366546)]] (duration: 12m 09s)

Dreamy_Jazz closed this task as Resolved.Jul 16 2024, 10:30 AM
Dreamy_Jazz moved this task from In Progress to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits