Page MenuHomePhabricator

Restrict creation of instances of Types with identity keys to wikilambda-create-enum-value
Closed, ResolvedPublic

Description

We should restrict creating instances of Enum types, which means that Type/Z4 and Function/Z8 are excluded from this, even though they also have an identity key.

How to flag an Enum type

An enum type must fulfill the following conditions:

  • It has an identity key
  • It has no other keys

To-Do:

  • Add right (inc. i18n)
  • Grant right to maintainers by default
  • Add edit rule with filter function
    • Add tests
  • Add create rule in getRequiredCreateRights
    • Add tests
  • Update docs
  • Grant right to wikifunctions-staff in production code

Event Timeline

Change #1048059 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] [wikifunctions] Grant wikifunctions-staff enum and converter rights

https://gerrit.wikimedia.org/r/1048059

Change #1048059 merged by jenkins-bot:

[operations/mediawiki-config@master] [wikifunctions] Grant wikifunctions-staff enum and converter rights

https://gerrit.wikimedia.org/r/1048059

Mentioned in SAL (#wikimedia-operations) [2024-07-02T13:17:31Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap sync-world: Backport for [[gerrit:1048059|[wikifunctions] Grant wikifunctions-staff enum and converter rights (T366610 T367270)]], [[gerrit:1047961|GrowthExperiments: add community updates module flag (T365877)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-02T13:20:02Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 sgimeno, jforrester, lucaswerkmeister-wmde: Backport for [[gerrit:1048059|[wikifunctions] Grant wikifunctions-staff enum and converter rights (T366610 T367270)]], [[gerrit:1047961|GrowthExperiments: add community updates module flag (T365877)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-02T13:27:54Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1048059|[wikifunctions] Grant wikifunctions-staff enum and converter rights (T366610 T367270)]], [[gerrit:1047961|GrowthExperiments: add community updates module flag (T365877)]] (duration: 10m 22s)

Jdforrester-WMF updated the task description. (Show Details)