Page MenuHomePhabricator
Create Task
Maniphest T366733

BE: Clean up or re-implement unused `issueRequest()` logic
Closed, ResolvedPublic
Actions

Description

What/Why:
We have recently discovered code in the orchestrator that is meaning/useless to us.
Namely in lib/util.js we never trigger req.issueRequest(). We should remove this and any related that we will never use or is outdated for us.
Other areas TBD, but this is one function for now.

How:

  1. Figure out if we really do not need this and/or if it will be useful to keep
  2. Remove entirely or re-implement if will be useful

Details

SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2024-09-24-221243 to 2024-10-08-175510operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-09-24-145528 to 2024-10-08-175830operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Event Timeline

ecarg created this task.Jun 5 2024, 5:53 PM
Jdforrester-WMF triaged this task as Low priority.Jun 12 2024, 4:32 PM
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
ecarg renamed this task from BE: Clean up unused code to BE: Clean up unused `issueRequest()` logic.Oct 3 2024, 2:53 AM
ecarg renamed this task from BE: Clean up unused `issueRequest()` logic to BE: Clean up or re-implement unused `issueRequest()` logic.
ecarg updated the task description. (Show Details)
ecarg added a comment.EditedOct 3 2024, 4:55 PM
  • Why'd we switch from preq to fetch (commit 73b816b5)?
  • Did we ever actually invoke issueRequest()?
CodeReviewBot added a project: Patch-For-Review.Oct 7 2024, 9:57 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/263

Remove deprecated request function

CodeReviewBot added a comment.Oct 7 2024, 9:57 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/240

Remove deprecated request function

Jdforrester-WMF subscribed.Oct 8 2024, 1:44 PM

Why'd we switch from preq to fetch (commit 73b816b5)?

Because preq is no longer supported and has security issues.

Did we ever actually invoke issueRequest()?

No. :-)

CodeReviewBot added a comment.Oct 8 2024, 5:54 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/263

Remove deprecated request function

Jdforrester-WMF assigned this task to ecarg.Oct 8 2024, 5:58 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
CodeReviewBot added a comment.Oct 8 2024, 5:58 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/240

Remove deprecated request function

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2024, 6:30 PM
gerritbot added a comment.Oct 9 2024, 2:03 PM

Change #1078949 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-09-24-145528 to 2024-10-08-175830

https://gerrit.wikimedia.org/r/1078949

gerritbot added a project: Patch-For-Review.Oct 9 2024, 2:03 PM

Change #1078950 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-09-24-221243 to 2024-10-08-175510

https://gerrit.wikimedia.org/r/1078950

gerritbot added a comment.Oct 9 2024, 2:06 PM

Change #1078949 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-09-24-145528 to 2024-10-08-175830

https://gerrit.wikimedia.org/r/1078949

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 9 2024, 2:12 PM
gerritbot added a comment.Oct 9 2024, 2:14 PM

Change #1078950 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-09-24-221243 to 2024-10-08-175510

https://gerrit.wikimedia.org/r/1078950

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2024, 2:32 PM
ecarg closed this task as Resolved.Fri, Nov 1, 1:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits