Page MenuHomePhabricator
Create Task
Maniphest T366746

Only show ListToggle if user has rights to lock or block on Special:CheckUser 'Get users'
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Discovered in the QA of T329493.

In T329493#9863795, @dom_walden wrote:

I found a few issues which I don't think are urgent:

  • When a user does not have rights to see the block form and does not see checkboxes next to usernames/IPs, they still see "Select: All, None, Invert". Clicking any of the options does not appear to do anything.

Using Special:Log as an example, the ListToggle is not displayed if the user does not have the rights to suppress log entries (and therefore have a button to press). As there is no block form or checkboxes, it means that these toggle links will do nothing and can safely be not included.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hide 'Get users' block buttons if there are no resultsmediawiki/extensions/CheckUsermaster+73 -6
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Jun 5 2024, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2024, 7:34 PM
Dreamy_Jazz moved this task from Inbox to CheckUser on the CheckUser board.Jun 5 2024, 7:50 PM
Dreamy_Jazz claimed this task.Nov 27 2024, 2:04 PM
Dreamy_Jazz set the point value for this task to 1.
gerritbot added a comment.Nov 27 2024, 2:46 PM

Change #1098526 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Hide 'Get users' block buttons if there are no results

https://gerrit.wikimedia.org/r/1098526

gerritbot added a project: Patch-For-Review.Nov 27 2024, 2:46 PM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)).EditedNov 27 2024, 2:46 PM

This isn't urgent and can be left for a while in 'Needs Review'. Just wanted to change tasks temporarily.

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Nov 27 2024, 2:47 PM
Dreamy_Jazz moved this task from Sprint Gong (November 18 - December 6) to Sprint Chimes (Dec. 9 - Jan. 17) on the Trust and Safety Product Sprint board.Dec 9 2024, 4:58 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)); removed Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)).
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.
gerritbot added a comment.Dec 12 2024, 5:23 PM

Change #1098526 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Hide 'Get users' block buttons if there are no results

https://gerrit.wikimedia.org/r/1098526

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Dec 12 2024, 5:25 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 12 2024, 5:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 12 2024, 6:00 PM
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Jan 10 2025, 10:03 AM

Viewing CheckUser with Admin rights:

checkuser_get_user_with_block.png (522×821 px, 57 KB)

Viewing CheckUser without Admin rights:

checkuser_get_user_without_block.png (346×1 px, 41 KB)

Test environment: local docker CheckUser 2.5 (d37a859) 07:30, 10 January 2025.

Dreamy_Jazz closed this task as Resolved.Jan 10 2025, 10:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits