Page MenuHomePhabricator
Create Task
Maniphest T366791

CollaborationKit CI is broken
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

includes/ResourceLoaderListStyleModule.php:9 PhanUndeclaredExtendedClass Class extends undeclared class \ResourceLoaderImageModule

includes/content/CollaborationHubContent.php:350 SecurityCheck-XSS Calling method \MediaWiki\Parser\ParserOutput::setText() in \CollaborationHubContent::fillParserOutput that outputs using tainted argument #1 (`$html`). (Caused by: ../../includes/parser/ParserOutput.php +853) (Caused by: includes/content/CollaborationHubContent.php +311; includes/content/CollaborationHubContent.php +304; includes/content/CollaborationHubContent.php +558; includes/content/CollaborationHubContent.php +552; ../../includes/Html/Html.php +191; includes/content/CollaborationHubContent.php +522; ../../includes/Message/Message.php +1124; ../../includes/Html/Html.php +191; includes/content/CollaborationHubContent.php +960; includes/content/CollaborationHubTOC.php +89; includes/content/CollaborationHubTOC.php +50; ../../includes/Html/Html.php +191; ../../includes/Message/Message.php +1124; ../../includes/Html/Html.php +191; includes/content/CollaborationHubTOC.php +50; ../../includes/Message/Message.php +1124; ../../includes/Html/Html.php +191)

What should have happened instead?:

  • CI passes

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix HTML escaping of some messagesmediawiki/extensions/CollaborationKitmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Jun 6 2024, 11:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2024, 11:30 AM
Novem_Linguae mentioned this in T366789: Replace jsduck with JSDoc3 in CollaborationKit.Jun 6 2024, 11:31 AM
Novem_Linguae edited projects, added ci-test-error; removed ci-test-error (WMF-deployed Build Failure).Jun 6 2024, 11:54 AM
matmarex subscribed.Jun 6 2024, 1:30 PM

There are some patches submitted that will fix at least some of the failures:

But none of them fixes all of the failures, so they're all failing. Let me try to bypass CI and merge them, and see what errors we're left with.

matmarex claimed this task.Jun 6 2024, 3:23 PM

That helped. The last remaining errors will be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CollaborationKit/+/1039722.

gerritbot added a comment.Jun 6 2024, 3:34 PM

Change #1039722 had a related patch set uploaded (by Novem Linguae; author: Bartosz Dziewoński):

[mediawiki/extensions/CollaborationKit@master] Fix HTML escaping of some messages

https://gerrit.wikimedia.org/r/1039722

gerritbot added a project: Patch-For-Review.Jun 6 2024, 3:34 PM
Novem_Linguae closed this task as Resolved.Jun 6 2024, 3:35 PM
gerritbot added a comment.Jun 6 2024, 3:46 PM

Change #1039722 merged by jenkins-bot:

[mediawiki/extensions/CollaborationKit@master] Fix HTML escaping of some messages

https://gerrit.wikimedia.org/r/1039722

Novem_Linguae reopened this task as Open.Jun 6 2024, 4:00 PM

More phan warnings :(

03:48:16 includes/ResourceLoaderListStyleModule.php:9 PhanUndeclaredExtendedClass Class extends undeclared class \ResourceLoaderImageModule

03:48:16 includes/content/CollaborationHubContent.php:350 SecurityCheck-XSS Calling method \MediaWiki\Parser\ParserOutput::setText() in \CollaborationHubContent::fillParserOutput that outputs using tainted argument #1 (`$html`). (Caused by: ../../includes/parser/ParserOutput.php +853) (Caused by: includes/content/CollaborationHubContent.php +311; includes/content/CollaborationHubContent.php +304; includes/content/CollaborationHubContent.php +558; includes/content/CollaborationHubContent.php +552; ../../includes/Html/Html.php +191; includes/content/CollaborationHubContent.php +522; ../../includes/Message/Message.php +1124; ../../includes/Html/Html.php +191; includes/content/CollaborationHubContent.php +960; includes/content/CollaborationHubTOC.php +89; includes/content/CollaborationHubTOC.php +50; ../../includes/Html/Html.php +191; ../../includes/Message/Message.php +1124; ../../includes/Html/Html.php +191; includes/content/CollaborationHubTOC.php +50; ../../includes/Message/Message.php +1124; ../../includes/Html/Html.php +191)
Novem_Linguae closed this task as Resolved.Jun 6 2024, 4:02 PM

Just kidding. Read the wrong Verified-1 log. Sorry about that!

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2024, 4:30 PM
Bawolff subscribed.Jun 6 2024, 5:43 PM

That said, perhaps its time to archive this extension unless someone else wants to take it up. It was never deployed and development work has largely stopped afaik.

Krinkle mentioned this in T380061: Flaky selenium test "Failed to wait for mediawiki.base to be ready" (tests/selenium/specs/page.js).Nov 15 2024, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits