Page MenuHomePhabricator

Update Metrics Platform Base Schemas to include instrument name
Closed, ResolvedPublic2 Estimated Story Points

Description

T370880

Background

Per the decision to use a single table per MP base schema (documented in T367057: [SPIKE] Document decision to use a single table per base schema), we need to introduce a field to capture the name of the instrument submitting events. Because there are multiple base schemas, this should be done in either the common fragment or a schema fragment, which is then mixed into the base schemas.

AC

  • An instrument_name field is added to the web and app Base Schemas
  • All MP schemas are updated and rematerialised

Requirements

  • Documentation

Related Objects

Event Timeline

This task needs more detail ;)

I want to combine all the client library refactoring work if possible

Internal awareness (Data Platform Engineering) of T367057: [SPIKE] Document decision to use a single table per base schema is necessary. @cjming is posting in slack on #data-engineering-collab to spread awareness.

phuedx renamed this task from Create a Metrics Platform schema fragment for instrument discriminating/filter fields to Update Metrics Platform base schemas to include instrument name.Aug 6 2024, 12:56 PM
phuedx renamed this task from Update Metrics Platform base schemas to include instrument name to Update Metrics Platform Base Schemas to include instrument name.
phuedx updated the task description. (Show Details)

This task needs more detail ;)

Hopefully it's a little clearer how this fits into the parent epic now.

cjming set the point value for this task to 2.

Change #1066880 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform common fragment to include instrument name identifier.

https://gerrit.wikimedia.org/r/1066880

Change #1066883 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform web base schema

https://gerrit.wikimedia.org/r/1066883

Change #1066889 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform app base schema

https://gerrit.wikimedia.org/r/1066889

This task is blocked on the review of https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/1067306 for T368326: Update Metrics Platform Client Libraries to accept experiment membership. Ideally, we can merge all schema updates at once so as to avoid having to update the schema IDs embedded in the client libraries multiple times.

Change #1071655 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform app base with common fragment bump

https://gerrit.wikimedia.org/r/1071655

Change #1066889 abandoned by Clare Ming:

[schemas/event/secondary@master] Update Metrics Platform app base schema

Reason:

in favor of https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/1071655

https://gerrit.wikimedia.org/r/1066889

Change #1071657 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform web base with common fragment bump

https://gerrit.wikimedia.org/r/1071657

Change #1071657 abandoned by Clare Ming:

[schemas/event/secondary@master] Update Metrics Platform web base with common fragment bump

Reason:

utter confusion

https://gerrit.wikimedia.org/r/1071657

Change #1071655 abandoned by Clare Ming:

[schemas/event/secondary@master] Update Metrics Platform app base with common fragment bump

Reason:

gah - confusion - starting over

https://gerrit.wikimedia.org/r/1071655

Change #1071662 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform app base major version bump with common updates:

https://gerrit.wikimedia.org/r/1071662

Change #1071663 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Update Metrics Platform web base major version bump with common updates:

https://gerrit.wikimedia.org/r/1071663

Change #1071666 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[schemas/event/secondary@master] Exclude Metrics Platform versions from compatibility errors due to typo correction introduced in earlier fragment on maxLength property.

https://gerrit.wikimedia.org/r/1071666

Change #1066883 abandoned by Clare Ming:

[schemas/event/secondary@master] Update Metrics Platform web base schema

Reason:

in favor of https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/1071663

https://gerrit.wikimedia.org/r/1066883

Change #1071666 merged by jenkins-bot:

[schemas/event/secondary@master] Exclude Metrics Platform versions from compatibility errors due to typo correction introduced in earlier fragment on maxLength property.

https://gerrit.wikimedia.org/r/1071666

Change #1066880 merged by jenkins-bot:

[schemas/event/secondary@master] Update Metrics Platform common fragment major bump:

https://gerrit.wikimedia.org/r/1066880

Change #1071662 merged by jenkins-bot:

[schemas/event/secondary@master] Update Metrics Platform app base major version bump with common updates:

https://gerrit.wikimedia.org/r/1071662

Change #1071663 merged by jenkins-bot:

[schemas/event/secondary@master] Update Metrics Platform web base major version bump with common updates:

https://gerrit.wikimedia.org/r/1071663