Page MenuHomePhabricator

AVA performance improvements
Closed, ResolvedPublic

Description

To be investigated.

Event Timeline

Aklapper triaged this task as Low priority.

Change #1039766 had a related patch set uploaded (by Aklapper; author: Aklapper):

[phabricator/antivandalism@wmf/stable] AVA: Check earlier if acting user is admin

https://gerrit.wikimedia.org/r/1039766

Change #1039786 had a related patch set uploaded (by Aklapper; author: Aklapper):

[phabricator/antivandalism@wmf/stable] Count user transactions in Maniphest only in last two million rows

https://gerrit.wikimedia.org/r/1039786

Regarding https://gerrit.wikimedia.org/r/1039786 , the SQL query for my account took on average approx. 1.95 seconds on a warm cache in production. After applying the patch, querying only the last two million rows instead of approx all 10 million rows, it takes on average approx. 0.54 seconds.

Change #1039791 had a related patch set uploaded (by Aklapper; author: Aklapper):

[phabricator/antivandalism@wmf/stable] Limit querying latest user transactions in Maniphest to recent IDs

https://gerrit.wikimedia.org/r/1039791

Regarding https://gerrit.wikimedia.org/r/1039791 , the SQL query for my account for the last 24hours (arbitrary value chosen for $hours, real value depends on the config of the Phabricator instance) went down from average 2.07 seconds to 0.17 seconds after restricting the query subset to the last half a million transactions.

Change #1039766 merged by Brennen Bearnes:

[phabricator/antivandalism@wmf/stable] AVA: Check earlier if acting user is admin

https://gerrit.wikimedia.org/r/1039766

Change #1039786 merged by Brennen Bearnes:

[phabricator/antivandalism@wmf/stable] Count user transactions in Maniphest only in last two million rows

https://gerrit.wikimedia.org/r/1039786

Change #1039791 merged by Brennen Bearnes:

[phabricator/antivandalism@wmf/stable] Limit querying latest user transactions in Maniphest to recent IDs

https://gerrit.wikimedia.org/r/1039791

Aklapper changed the task status from Open to Stalled.Jun 20 2024, 9:37 AM

Deployed on 2024-06-25; setting status to resolved.