Page MenuHomePhabricator

Use localised parentheses in Special:Contributions, RecentChanges and ShortPages
Closed, ResolvedPublic

Description

Some instances of parentheses in Special:Contributions and others should be replaced with the localised version (when it exists). The unlocalised ones sometimes don't produce the typographically ideal sequence of characters.

For example, '(差異 | 歷史)' '(diff | hist)' in Special:Contributions on mediawikiwiki does not use the localised parentheses when I specify Chinese [1][2].

Other examples:

  • the day name such as (星期五), and the links after username (對話 | 貢獻) in RecentChanges [3]
  • '(歷史)' in ShortPages‎ [4]

[1] https://www.mediawiki.org/wiki/Special:Contributions/Whym?uselang=zh-hant
[2] https://www.mediawiki.org/wiki/MediaWiki:Parentheses/zh-hant
[3] https://www.mediawiki.org/w/index.php?title=Special:RecentChanges&tagfilter=Added+PHP+closing+tag&uselang=zh-hant
[4] https://www.mediawiki.org/w/index.php?title=Special:ShortPages&uselang=zh-hant


Version: 1.19
Severity: normal

Details

Reference
bz34702

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:14 AM
bzimport set Reference to bz34702.
bzimport added a subscriber: Unknown Object (MLST).

Some instances of parentheses in Special:Contributions and others should be
replaced with the localised version (when it exists).

Could you give an example of how this should look and a link to some supporting documentation of this?

These lists should use pipe-separator and parentheses messages.

Fixed for Special:Contributions in r112410 and r112412.

If you feel like it, please give creating a patch to fix this in the other pages you mentioned a go.

With r112433 many more issues have been resolved. Please provide specific cases of this in core when reopening the bug.

I've also fixed an issue in Translate (Special:Translations), and found issues in SemanticMediaWiki that I haven't resolved.

Created attachment 10122
supplemental changes to replace parentheses literals with localised parentheses in Special:Contributions and Special:RecentChanges

I noticed link items like '(talk|contribs)' in RecentChanges were still not i18nised. Please review and apply the patch to i18nise those parentheses used in the RecentChanges and history pages.

Attached:

(In reply to comment #5)

Created attachment 10122 [details]

Very nice. Thank you! I've committed this, with very minor whitespace updates in r112589. I'll grep for the patters and will see if there's more low hanging fruit...

Attached:

Made another commit for this: r112591. Kind of done with this now ;).