Page MenuHomePhabricator

Autoname unnamed parent references (MMVP)
Closed, ResolvedPublic

Description

The current MMVP approach in Cite implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1040265 still needs to support to give autonames whenever a reference is saved and extended that did not have a name yet. Follow the same internal pattern as is used for reuse, eg. use the "list key" which looks like "auto/#" until the "literal/:0" automatic name has been assigned during save.

Use the the same ":0", ":1"... naming pattern as already exists for normal ref reuse.

The patch currently already ensures that autonames are saved whenever a reference is used as parent. Just the numbering of the autonames does not seem to match at the moment and needs so more work it seems.

Should be possible to include a QUnit test—especially if it helps to follow TDD as we write the feature.

Event Timeline

awight renamed this task from Support the ability that extending refrences creates autonames on save if the parent does not have a name yet (MMVP) to Autoname unnamed parent references (MMVP).Jun 12 2024, 7:31 AM

Change #1040265 had a related patch set uploaded (by Awight; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [WIP] Implement support to convert extended notes with auto names

https://gerrit.wikimedia.org/r/1040265

Change #1042290 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Add a QUnit test for autonaming during conversion

https://gerrit.wikimedia.org/r/1042290

Change #1042901 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Use full listKey for extends in the model

https://gerrit.wikimedia.org/r/1042901

awight subscribed.

Change #1043755 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Cleanup: extract literal name functions

https://gerrit.wikimedia.org/r/1043755

Change #1042901 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use full listKey for extends in the model

https://gerrit.wikimedia.org/r/1042901

Change #1040265 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Implement support to convert extended notes with auto names

https://gerrit.wikimedia.org/r/1040265

Change #1043755 abandoned by Awight:

[mediawiki/extensions/Cite@master] Cleanup: extract literal name functions

https://gerrit.wikimedia.org/r/1043755