Page MenuHomePhabricator

findTypeIdentity Function Is Broken
Closed, ResolvedPublic

Description

Description

The findTypeIdentity function sometimes returns a Z4, sometimes a Z9, and sometimes null. It doesn't always do the right thing. This function should be split out into some more specific functions
(like findTypeIdentityAsReference) for different use cases.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • build a better type identity gettin' function

Completion checklist

Details

Event Timeline

ecarg renamed this task from findIdentity Function Is Broken to findTypeIdentity Function Is Broken.Aug 1 2024, 7:16 PM
ecarg updated the task description. (Show Details)

Change #1064031 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124

https://gerrit.wikimedia.org/r/1064031

Change #1064031 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124

https://gerrit.wikimedia.org/r/1064031

Change #1080294 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (09d91f1)

https://gerrit.wikimedia.org/r/1080294

Change #1080294 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (09d91f1)

https://gerrit.wikimedia.org/r/1080294

Change #1090892 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-10-15-192817 to 2024-11-13-145636

https://gerrit.wikimedia.org/r/1090892

Change #1090893 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-10-10-202633 to 2024-11-12-161156

https://gerrit.wikimedia.org/r/1090893

Change #1090892 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-10-15-192817 to 2024-11-13-145636

https://gerrit.wikimedia.org/r/1090892

Change #1090893 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-10-10-202633 to 2024-11-12-161156

https://gerrit.wikimedia.org/r/1090893

Change #1115032 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115032

Change #1115032 abandoned by Cory Massaro:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

Reason:

already done

https://gerrit.wikimedia.org/r/1115032