Page MenuHomePhabricator

Unable to create converters using the UI as identity fields cannot be set
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. Create a converter Z64 or Z46 using the Special Create object page:
  2. Fill the necessary fields
    • when trying to fill "identity", this should be Z0, but the selector doesn't allow Z0 to be chosen.
  3. Try to publish
  4. Not wellformed errors are flagged

Observed behavior:

Expected behavior (Acceptance criteria):

  • When creating an instance of an object that has an identity key, the field should be initialized to Z0 and disabled.

To-Do

  • Update function-schemata definitions of Z46 and Z64 to set their identity key to identity=true
  • Add Z46 and Z64 to the list of types that have an identity key but are not enums
  • Assure proper behavior of UI with Z46K1 and Z64K1 as proper identity keys

Completion checklist

Event Timeline

gengh renamed this task from Unable to create converters using the UI to Unable to create converters using the UI as identity fields cannot be set.

Change #1041657 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (50415ed)

https://gerrit.wikimedia.org/r/1041657

Change #1041657 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (50415ed)

https://gerrit.wikimedia.org/r/1041657

Change #1042268 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-05-31-163732 to 2024-06-11-161031

https://gerrit.wikimedia.org/r/1042268

Change #1042269 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-06-05-003919 to 2024-06-11-223956

https://gerrit.wikimedia.org/r/1042269

Change #1042268 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-05-31-163732 to 2024-06-11-161031

https://gerrit.wikimedia.org/r/1042268

Change #1042269 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-06-05-003919 to 2024-06-11-223956

https://gerrit.wikimedia.org/r/1042269

Change #1046600 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add converters as linked typed

https://gerrit.wikimedia.org/r/1046600

Change #1046600 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add converters as linked typed

https://gerrit.wikimedia.org/r/1046600

Change #1047008 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Use isEnumType in selector and isCustomEnum for creating literals

https://gerrit.wikimedia.org/r/1047008

Change #1047008 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Use isEnumType in selector and isCustomEnum for creating literals

https://gerrit.wikimedia.org/r/1047008

Change #1047077 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.43.0-wmf.10] Use isEnumType in selector and isCustomEnum for creating literals

https://gerrit.wikimedia.org/r/1047077

Change #1047077 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.43.0-wmf.10] Use isEnumType in selector and isCustomEnum for creating literals

https://gerrit.wikimedia.org/r/1047077

Mentioned in SAL (#wikimedia-operations) [2024-06-18T23:05:31Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1047077|Use isEnumType in selector and isCustomEnum for creating literals (T367159)]], [[gerrit:1047188|findAddedContentNeedingReference was removed accidentally (T367920)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-18T23:10:15Z] <jforrester@deploy1002> jforrester, kemayo: Backport for [[gerrit:1047077|Use isEnumType in selector and isCustomEnum for creating literals (T367159)]], [[gerrit:1047188|findAddedContentNeedingReference was removed accidentally (T367920)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-18T23:22:47Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1047077|Use isEnumType in selector and isCustomEnum for creating literals (T367159)]], [[gerrit:1047188|findAddedContentNeedingReference was removed accidentally (T367920)]] (duration: 17m 16s)