Steps to replicate the issue (include links if applicable):
Instance 1: From the "Add image details screen"
- Open image recommendations
- Click "Yes" to add this image"
- From the "Add image details" screen, click on image file name to open commons listing
- Choose "Search" in top right hand corner
Instance 2: From the article view in Image recs
- Open image recommendations
- Click on "View article" to expand the article
- Choose "Search" in top right hand corner
What happens?:
- Search bar is not displayed / functional
What should have happened instead?:
- Search bar should be displayed and functional
Software version
7.5.3 (3626)
Reference
We have already fixed this in one location: T363942: Commons view search field not displaying within Image Recs
Engineering Notes
The app contains a mixture of custom navigation bars (added manually in the base superclass ViewController.swift) and system navigation bars. We usually try to use the default system navigation bar if possible, unless some special behavior is needed where we resort to hiding the system bar and using the custom bar. It is likely that this bug is the result of a missing call to hide or show the system navigation bar:
navigationController?.setNavigationBarHidden(false or true, animated: false).