Page MenuHomePhabricator

Search not functioning within Image recs: commons view & article view
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Instance 1: From the "Add image details screen"

  1. Open image recommendations
  2. Click "Yes" to add this image"
  3. From the "Add image details" screen, click on image file name to open commons listing
  4. Choose "Search" in top right hand corner

Instance 2: From the article view in Image recs

  1. Open image recommendations
  2. Click on "View article" to expand the article
  3. Choose "Search" in top right hand corner

What happens?:

  • Search bar is not displayed / functional

What should have happened instead?:

  • Search bar should be displayed and functional

Software version
7.5.3 (3626)

Reference

We have already fixed this in one location: T363942: Commons view search field not displaying within Image Recs

Engineering Notes

The app contains a mixture of custom navigation bars (added manually in the base superclass ViewController.swift) and system navigation bars. We usually try to use the default system navigation bar if possible, unless some special behavior is needed where we resort to hiding the system bar and using the custom bar. It is likely that this bug is the result of a missing call to hide or show the system navigation bar:

navigationController?.setNavigationBarHidden(false or true, animated: false).

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

I want to solve the issue regarding to this bug ,I am new to this community. Can any one help me to find the source repository

@GauriGupta

Source repository is here - https://github.com/wikimedia/wikipedia-ios

Note it may be difficult to see the Image Recommendations explore feed card unless you have made 50+ edits from your Wikipedia account. Temporarily changing this flag to true will help you bypass that requirement and get into the image recommendations flow.

@Tsevener I dont see that feature flag file existing anymore. I'd like to attempt this but not sure how to change the flag to get an account to bypass that requirement

@Hjavery11 Sorry about that, we are actively changing some of this logic. What you can do for now is temporarily remove this user.editCount > 50 conditional here. Then pulling to refresh on Explore should cause the image recommendations card to appear, if you are logged in. Just make sure you don't commit that change. Thanks!

Is anyone actively working on this? If not I will be taking an attempt at it.

@ABorbaWMF @HNordeenWMF I suspect the system nav bar release may have fixed this one. Can one of you test in the current App Store build and confirm, and close if so? Thanks!

ABorbaWMF claimed this task.

No longer reproducible. Tested on 7.7.1 (4944)