Page MenuHomePhabricator
Create Task
Maniphest T367234

Create button to merge "Unknown: Shares contact information"
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Create an option for a "not a duplicate" button on deduper to mark records as not duplicates but also create a relationship type = "Unknown: Shares contact information" if the donors share any type of contact information

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix typo causing dedupe js to not workwikimedia/fundraising/crmmaster+1 -1
Add default for our new settingwikimedia/fundraising/crmmaster+2 -1
Add support for creating relationship on non-dupeswikimedia/fundraising/crmmaster+108 -11
Customize query in gerrit

Related Objects

Event Timeline

• NNichols created this task.Jun 11 2024, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2024, 7:45 PM
AKanji-WMF added a project: FR-Civi-Dedupe.Jul 8 2024, 8:30 PM
AKanji-WMF moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
Dwisehaupt set the point value for this task to 4.Jul 11 2024, 4:55 PM
XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jul 16 2024, 7:09 PM
XenoRyet added a project: Fundraising Sprint: neveruse().Jul 16 2024, 7:23 PM
AKanji-WMF triaged this task as High priority.Jul 17 2024, 6:21 PM
AKanji-WMF mentioned this in T371308: 2024 Sprint O - Priorities.Jul 29 2024, 7:00 PM
AKanji-WMF edited projects, added Fundraising Sprint: ogFunction(); removed Fundraising Sprint: neveruse().Jul 30 2024, 7:37 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint: ogFunction() board.Jul 31 2024, 12:39 AM
Eileenmcnaughton added a comment.Jul 31 2024, 12:45 AM

@NNichols would it be case that

  1. IF a contact is marked not a duplicate AND they have
  2. street_address
  3. or phone number
  4. or email

in common with the not-duplicate contact the relationship is created

OR is the decision to create the relationship made per pair by the deduper?

Eileenmcnaughton added a comment.Jul 31 2024, 12:46 AM

Also - do we want to add this relationship to existing contact pairs marked 'not duplicate'

• NNichols removed a subscriber: Aklapper.Jul 31 2024, 4:48 PM

Yes if they share any one of those contact pieces, we'll want it to create the relationship and mark them not a duplicate.
I don't think it should not happen automatically. I think we'd at least want someone to make that decision while working in deduper. Can this be a separate button from "Not a duplicate"?

Are you asking if we want to go back and create this for contacts we've reviewed in the past?

Eileenmcnaughton added a comment.Jul 31 2024, 7:38 PM

"Are you asking if we want to go back and create this for contacts we've reviewed in the past?"

  • yes that was the question
Eileenmcnaughton moved this task from Backlog to Doing on the FR-Civi-Dedupe board.Aug 7 2024, 9:16 PM
gerritbot added a comment.Aug 8 2024, 3:05 AM

Change #1060526 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add support for creating relationship on non-dupes

https://gerrit.wikimedia.org/r/1060526

gerritbot added a project: Patch-For-Review.Aug 8 2024, 3:05 AM
gerritbot added a comment.Aug 8 2024, 3:28 AM

Change #1060527 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add default for our new setting

https://gerrit.wikimedia.org/r/1060527

Eileenmcnaughton moved this task from Doing to Ready for Review on the Fundraising Sprint: ogFunction() board.Aug 12 2024, 7:18 PM
AKanji-WMF edited projects, added Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(); removed Fundraising Sprint: ogFunction().Aug 13 2024, 8:07 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary() board.Aug 13 2024, 8:37 PM
Eileenmcnaughton moved this task from Doing to Ready for Review on the Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary() board.Aug 14 2024, 10:57 PM
gerritbot added a comment.Aug 21 2024, 2:58 PM

Change #1060526 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add support for creating relationship on non-dupes

https://gerrit.wikimedia.org/r/1060526

gerritbot added a comment.Aug 21 2024, 2:58 PM

Change #1060527 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add default for our new setting

https://gerrit.wikimedia.org/r/1060527

Ejegg moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary() board.Aug 21 2024, 4:08 PM
Eileenmcnaughton added a comment.Aug 22 2024, 1:10 AM

I just deployed this & tested it - the relationship is created - e g - https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=37538645&selectedChild=rel - but the screen freezes & needs to be refreshed to continue on - will need to see why

status = ok to use but annoying to use

gerritbot added a comment.Aug 22 2024, 7:07 AM

Change #1064643 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix typo causing dedupe js to not work

https://gerrit.wikimedia.org/r/1064643

gerritbot added a comment.Aug 22 2024, 7:08 AM

Change #1064643 merged by Eileen:

[wikimedia/fundraising/crm@master] Fix typo causing dedupe js to not work

https://gerrit.wikimedia.org/r/1064643

Eileenmcnaughton moved this task from Pending Deployment to Done on the Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary() board.Aug 22 2024, 7:28 AM

I fixed the annoying thing - this should be working now

XenoRyet closed this task as Resolved.Aug 26 2024, 7:12 PM
XenoRyet set Final Story Points to 4.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits