Maniphest T367417

Enable LinterParseOnDerivedDataUpdate in production
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Jun 13 2024, 2:45 PM

Tags

Referenced Files

None

Subscribers

Description

LinterParseOnDerivedDataUpdate is currently set to false, to avoid redundant parsing/linting while we still trigger parses from Parsoid's pre-generation logic in RESTbase. Once that is disabled, LinterParseOnDerivedDataUpdate needs to be turned on to make sure lint data gets updated when pages are affected by template changes.

See also: T367418: ChangeProp: stop making no-cache requests to parsoid endpoints in RESTBase

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Enable linter jobs on derived data update	operations/mediawiki-config	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T324931 Clean up open RESTBase related tickets
		Open		None	T262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
		Resolved		Jgiannelos	T344944 Move Parsoid endpoints out of RESTBase
		Resolved		Jgiannelos	T367418 ChangeProp: stop making no-cache requests to parsoid endpoints in RESTBase
		Resolved		Jgiannelos	T367417 Enable LinterParseOnDerivedDataUpdate in production

Event Timeline

daniel created this task.Jun 13 2024, 2:45 PM

daniel added a parent task: T367418: ChangeProp: stop making no-cache requests to parsoid endpoints in RESTBase.Jun 13 2024, 2:49 PM

daniel mentioned this in T361413: Parsoid should perhaps use LinkUpdate job for lints instead of special Linter API/Hook.

daniel mentioned this in T361013: Update lint tables independently of changeprop/restbase.Jun 13 2024, 2:51 PM

daniel mentioned this in T359964: Move page lint job outside of restbase request/response cycle to allow completely disabling cassandra writes.

daniel updated the task description. (Show Details)Jun 13 2024, 2:54 PM

MSantos moved this task from Unsorted to Parsoid pile on the RESTBase Sunsetting board.Jun 20 2024, 11:45 AM

MSantos removed a project: Content-Transform-Team.Jun 20 2024, 2:07 PM

MSantos moved this task from Backlog to Tracking on the MediaWiki-extensions-Linter board.Jun 27 2024, 2:17 PM

Jgiannelos added a project: Content-Transform-Team-WIP.Jul 9 2024, 4:25 PM

Change #1053019 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[operations/mediawiki-config@master] Enable linter jobs on derived data update

https://gerrit.wikimedia.org/r/1053019

gerritbot added a project: Patch-For-Review.Jul 9 2024, 4:25 PM

Jgiannelos claimed this task.Jul 9 2024, 4:26 PM

Jgiannelos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.

Change #1053019 abandoned by Jgiannelos:

[operations/mediawiki-config@master] Enable linter jobs on derived data update

https://gerrit.wikimedia.org/r/1053019

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2024, 7:30 AM

Closing this one after:
https://phabricator.wikimedia.org/T361013#9972305

From logstash I can see an edit logged in the doUpdate hook like this one:
https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-mediawiki-1-7.0.0-1-2024.07.11?id=JCCroJABbv8L2HoqFnPU

Jgiannelos closed this task as Resolved.Jul 11 2024, 7:32 AM

Michael subscribed.Jul 23 2024, 11:32 AM

ABreault-WMF mentioned this in T370805: Investigate parse time increase from 2024-07-11 deploy.Jul 23 2024, 7:33 PM