Page MenuHomePhabricator

Height of images inside divs are not respected due to a css !important rule in Vector 2022
Closed, DuplicatePublicBUG REPORT

Assigned To
None
Authored By
Theklan
Jun 14 2024, 6:01 AM
Referenced Files
F55297556: irudia.png
Jun 14 2024, 6:02 AM
F55297535: irudia.png
Jun 14 2024, 6:02 AM
F55297508: irudia.png
Jun 14 2024, 6:02 AM
F55297516: irudia.png
Jun 14 2024, 6:02 AM
F55297483: irudia.png
Jun 14 2024, 6:02 AM

Description

Steps to replicate the issue (include links if applicable):

What happens?: the height of the images isn't limited as expected due to this rule:

body.skin--responsive .mw-parser-output a > img, body.skin--responsive .mw-parser-output noscript > img {height: auto !important;}

What should have happened instead?: The !important shouldn't be there

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

The same is happening at AvoinGLAM page:

irudia.png (811×1 px, 1 MB)

https://meta.wikimedia.org/wiki/AvoinGLAM

At Basque Wikipedia main page

These shouldn't be so high

irudia.png (443×1 px, 114 KB)

All this buttons had the same height

irudia.png (752×1 px, 1 MB)

All this images should have the height of the third one

irudia.png (285×1 px, 149 KB)

All this images should have the height of the last one

irudia.png (517×1 px, 517 KB)

All this is coming from

body.skin--responsive .mw-parser-output a > img, body.skin--responsive .mw-parser-output noscript > img {height: auto !important;}

Tonight @Jdlrobson added a new !important rule to the height at Basque Wikipedia main page templatestyle, which solves "for now" the visual problem. However, having two conflicting !important rules one over the next one doesn't look like a good long-term solution.

I'm sure that this is related, but I was asked to open a new ticket.

@Theklan - just to check the edits yesterday addressed this issue for now? We will work on a improving this with a long term fix so we can revert those !important rules.

Yes, they seem solved, but still I find that some heights are not as expected. Anyway, I have opened a subtask.

Okay thanks for writing this up so concisely - it was very helpful! . I've updated T367463 and made sure to understand the issue here and fold its requirements into T367463 to make sure this is fixed comprehensively.