Page MenuHomePhabricator
Create Task
Maniphest T36754

Collapsible navigation toggle should be a link
Closed, ResolvedPublic
Actions

Description

patch for displaying the collapsible nav items as links

This bug is mentioned in the accessibility report carried out by the swiss foundation "Access for all" (see paragraph 1.3.2.1).
http://www.thirdageonline.eu/project-tao-2/software-development/mediawiki-accessibility-enhancements/

The navigation items that collapse subitems are not displayed as links, which makes it impossible for users of screen readers to understand that these actually are links.

I propose the attached patch to fix this one. The patch adds h5-tags to the collapsible items and extends its CSS definitions to still look the same.

Version: unspecified
Severity: normal

Attached:

subnav-links.patch1 KBDownload

Details

Reference
bz34754

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:17 AM
• bzimport added a project: Vector (legacy skin).
• bzimport set Reference to bz34754.
kai.nissen created this task.Feb 27 2012, 5:59 PM
kai.nissen added a comment.Feb 27 2012, 6:20 PM

Sorry, the patch adds link tags to the collapsible items, h5 tags are already there.

• brion added a comment.Feb 28 2012, 12:29 AM

This would seem to make the portal section titles links even if they are not collapsible...? Should this only be done in JS when the collapsible links are being set up, maybe?

TheDJ added a comment.Feb 28 2012, 12:31 AM

or we can just add role's of course.

kai.nissen added a comment.Mar 8 2012, 2:25 PM

patch for displaying the collapsible nav items as links

I took Brion's comment into consideration. The navigation elements' content is changed during the javascript methods that add the collapsible css class, so collapsible/expandable headings become links "on demand".

Attached:

subnav-links.patch1 KBDownload

Jdlrobson added a comment.May 23 2012, 2:55 PM

https://gerrit.wikimedia.org/r/8605
One last thought.. it is the href required?

kai.nissen added a comment.May 23 2012, 3:16 PM

Yes, links missing the href attribute are not recognized by screen readers.

Aklapper added a project: Accessibility.Dec 9 2019, 1:21 PM
Aklapper removed a parent task: T2367: Several markup accessibility issues.Dec 9 2019, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL