Page MenuHomePhabricator
Create Task
Maniphest T367574

[Epic] Remove code for Special:EditGrowthConfig
Open, In Progress, MediumPublic
Actions

Description

Once MediaWiki-extensions-CommunityConfiguration is deployed on all Growth wikis, we should remove code for CommunityConfiguration 1.0 (aka Special:EditGrowthConfig). This will be the last step to complete T323811: [EPIC] Community configuration 2.0: Factor Community configuration out of GrowthExperiments. Keeping the code in would be also a form of Technical-Debt.

Details

SubjectRepoBranchLines +/-
Config: remove community configuration legacymediawiki/extensions/GrowthExperimentsmaster+57 -6 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT265163 Create a system to encode best practices into editing experiences
 OpenNoneT327563 Enable volunteers to configure Edit Check in ways that align with project policies and norms
 OpenNoneT327655 Epic: Migration of some GrowthExperiments features into MediaWiki core
 OpenNoneT323811 [EPIC] Community configuration 2.0: Factor Community configuration out of GrowthExperiments
 ResolvedDMburuguT367429 [Epic] FY 2024-25 Growth Maintenance Work
 In ProgressSgsT367574 [Epic] Remove code for Special:EditGrowthConfig
 Resolved• Urbanecm_WMFT367575 Structured Mentor list should load its data using the CommunityConfiguration extension
 Resolved• Urbanecm_WMFT368739 CommunityConfiguration: Allow client extensions to provide their own tag names
 ResolvedBUG REPORT• Urbanecm_WMFT368741 CommunityConfiguration's WikiPageStore does not support non-object input
 Resolved• Urbanecm_WMFT367576 Ensure ORES topics are not loaded through legacy CommunityConfiguration code
 OpenNoneT380586 [EPIC] Ensure GrowthExperiments CI pipeline is using CommunityConfiguration to run tests
 Resolved• Urbanecm_WMFT369709 Switch `GEUseCommunityConfigurationExtension` to `true` in extension.json
 ResolvedMichaelT380585 Run ApiStructureTest with CommunityConfiguration extension enabled
 ResolvedMichaelT380581 Migrate GrowthExperiments selenium tests to CommunityConfiguration 2.0
 Resolved• Urbanecm_WMFT380580 Migrate ComputedUserImpactLookupTest test to CommunityConfiguration 2.0
 Resolved• Urbanecm_WMFT384423 Migrate GrowthExperiments API tests to CommunityConfiguration 2.0
 Resolved• Urbanecm_WMFT383330 Deprecate calling legacy Community Configuration
 Resolved• Urbanecm_WMFT383329 Drop support for morelike support from GrowthExperiments
 Resolved• Urbanecm_WMFT384225 Discontinue the initWikiConfig.php maintenance script in GrowthExperiments
 ResolvedCyndymediawiksimT384229 Cover CommunityStructuredMentorProvider and CommunityStructuredMentorWriter by appropriate tests
 ResolvedBUG REPORTMichaelT386629 Enforce GrowthConfigValidation::MAX_TEMPLATES_IN_COLLECTION using CommunityConfiguration
 ResolvedCyndymediawiksimT386692 Cover CommunityConfigurationLoader and ConfigurationValidator by appropriate tests
 OpenNoneT388516 Delete legacy config pages
 OpenCyndymediawiksimT388787 Remove now unused PHP config settings
 OpenSgsT389254 Refactor to consolidate PHP abstractions after removal of Special:EditGrowthConfig code
 OpenSgsT388227 De-facto remove code for Special:EditGrowthConfig
 OpenNoneT390167 Avoid per-wiki topic configuration GENewcomerTasksOresTopicConfig

Event Timeline

• Urbanecm_WMF created this task.Jun 14 2024, 4:00 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 14 2024, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Urbanecm_WMF changed the task status from Open to Stalled.Jun 14 2024, 4:01 PM
• Urbanecm_WMF triaged this task as Low priority.
• Urbanecm_WMF moved this task from Inbox to Blocked on the Growth-Team board.

Not ready yet.

• Urbanecm_WMF edited projects, added GrowthExperiments-EditGrowthConfig, CommunityConfiguration-Adoption; removed MediaWiki-extensions-CommunityConfiguration.Jun 14 2024, 4:01 PM
• Urbanecm_WMF added subtasks: T367575: Structured Mentor list should load its data using the CommunityConfiguration extension, T367576: Ensure ORES topics are not loaded through legacy CommunityConfiguration code.Jun 14 2024, 4:13 PM
• Urbanecm_WMF added a parent task: T323811: [EPIC] Community configuration 2.0: Factor Community configuration out of GrowthExperiments.
DMburugu added a parent task: T367429: [Epic] FY 2024-25 Growth Maintenance Work.Jul 3 2024, 2:12 PM
Michael changed the status of subtask T367575: Structured Mentor list should load its data using the CommunityConfiguration extension from Open to Stalled.Jul 24 2024, 10:27 AM
Michael added a subtask: T369709: Switch `GEUseCommunityConfigurationExtension` to `true` in extension.json.Oct 7 2024, 6:23 PM
• Urbanecm_WMF added subtasks: T380580: Migrate ComputedUserImpactLookupTest test to CommunityConfiguration 2.0, T380581: Migrate GrowthExperiments selenium tests to CommunityConfiguration 2.0.Nov 22 2024, 12:07 PM
• Urbanecm_WMF removed subtasks: T380581: Migrate GrowthExperiments selenium tests to CommunityConfiguration 2.0, T380580: Migrate ComputedUserImpactLookupTest test to CommunityConfiguration 2.0, T369709: Switch `GEUseCommunityConfigurationExtension` to `true` in extension.json.Nov 22 2024, 1:01 PM
• Urbanecm_WMF added a subtask: T380586: [EPIC] Ensure GrowthExperiments CI pipeline is using CommunityConfiguration to run tests.
• Urbanecm_WMF added a comment.Jan 9 2025, 2:08 PM
This comment was removed by • Urbanecm_WMF.
• Urbanecm_WMF added a subtask: T383329: Drop support for morelike support from GrowthExperiments.Jan 9 2025, 2:11 PM
• Urbanecm_WMF added a subtask: T384225: Discontinue the initWikiConfig.php maintenance script in GrowthExperiments.Jan 20 2025, 3:06 PM
• Urbanecm_WMF mentioned this in T384229: Cover CommunityStructuredMentorProvider and CommunityStructuredMentorWriter by appropriate tests.Jan 20 2025, 3:19 PM
• Urbanecm_WMF added a subtask: T384229: Cover CommunityStructuredMentorProvider and CommunityStructuredMentorWriter by appropriate tests.
• Urbanecm_WMF mentioned this in T384919: SUL3 prevents GrowthExperiments from accessing CommunityConfiguration on testwiki.Jan 28 2025, 12:16 PM
Etonkovidova closed subtask T383329: Drop support for morelike support from GrowthExperiments as Resolved.Jan 28 2025, 11:16 PM
Etonkovidova closed subtask T367576: Ensure ORES topics are not loaded through legacy CommunityConfiguration code as Resolved.Jan 30 2025, 1:31 AM
• Urbanecm_WMF closed subtask T384225: Discontinue the initWikiConfig.php maintenance script in GrowthExperiments as Resolved.Jan 31 2025, 10:49 AM
Etonkovidova closed subtask T383330: Deprecate calling legacy Community Configuration as Resolved.Feb 5 2025, 11:42 PM
KStoller-WMF edited projects, added Growth-Team (Maintenance); removed Growth-Team.Feb 12 2025, 5:38 PM
DMburugu renamed this task from Remove code for Special:EditGrowthConfig to [Epic] Remove code for Special:EditGrowthConfig.Feb 12 2025, 5:40 PM
DMburugu added a project: Epic.
DMburugu moved this task from Backlog to Removing legacy Community Configuration on the Growth-Team (Maintenance) board.
KStoller-WMF assigned this task to • Urbanecm_WMF.Feb 12 2025, 6:03 PM
• Urbanecm_WMF mentioned this in T386257: Replace CommunityStructuredMentorListValidator with a JSON schema validator.Feb 12 2025, 7:37 PM
• Urbanecm_WMF closed subtask T367575: Structured Mentor list should load its data using the CommunityConfiguration extension as Resolved.Feb 12 2025, 7:39 PM
Sgs added a subtask: T386629: Enforce GrowthConfigValidation::MAX_TEMPLATES_IN_COLLECTION using CommunityConfiguration.Feb 17 2025, 5:15 PM
gerritbot added a comment.Feb 18 2025, 9:26 AM

Change #1120173 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [DNM] Remove CC legacy

https://gerrit.wikimedia.org/r/1120173

gerritbot added a project: Patch-For-Review.Feb 18 2025, 9:26 AM
• Urbanecm_WMF mentioned this in T386692: Cover CommunityConfigurationLoader and ConfigurationValidator by appropriate tests.Feb 18 2025, 9:34 AM
Michael mentioned this in T380496: Port \GrowthExperiments\Config\ConfigHooks::onPageSaveComplete to PageUpdated event.Tue, Mar 4, 2:42 PM
KStoller-WMF changed the task status from Stalled to In Progress.Wed, Mar 5, 5:15 PM
KStoller-WMF raised the priority of this task from Low to Medium.
Michael subscribed.Tue, Mar 11, 10:25 AM
Sgs claimed this task.Mon, Mar 17, 12:38 PM
Michael removed a subtask: T388227: De-facto remove code for Special:EditGrowthConfig.Tue, Mar 18, 9:16 PM
gerritbot added a comment.Tue, Mar 25, 8:16 PM

Change #1120173 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Config: remove community configuration legacy

https://gerrit.wikimedia.org/r/1120173

Maintenance_bot removed a project: Patch-For-Review.Tue, Mar 25, 8:30 PM
Etonkovidova closed subtask T386629: Enforce GrowthConfigValidation::MAX_TEMPLATES_IN_COLLECTION using CommunityConfiguration as Resolved.Tue, Mar 25, 11:18 PM
Sgs closed subtask T384229: Cover CommunityStructuredMentorProvider and CommunityStructuredMentorWriter by appropriate tests as Resolved.Thu, Mar 27, 3:18 PM
Sgs closed subtask T386692: Cover CommunityConfigurationLoader and ConfigurationValidator by appropriate tests as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits