Page MenuHomePhabricator

Remove old limited width toggle
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: Deploy date September 9

Background

Now that the appearances menu is deployed to all wikis (T371020), we can remove the old limited width toggle. This is important as currently we are maintaining two views at additional maintenance and performance cost. We are not currently monitoring the old experience so there is a high likelihood of visual regressions if we do not do this.

User story

  • As a user, I want the performance of the site to be as fast as possible, without unused code being shipped and for no visual regressions in the limited width function

Requirements

  • Remove limitedWidthToggle.js
  • Updating pixel to remove limited width related code
  • Some styles from BottomDock.less should be removed
  • skin.mustache should be updated

Requirement

Remove the old limited width toggle from the Vector 2022 skin, ensuring performance improvements by eliminating unused code, including removing limitedWidthToggle.js and other related styles and code.

BDD

Feature: Remove Old Limited Width Toggle

  Scenario: Appearance menu shows font size and width instead of width toggle
    Given the user visits a page in the Vector 2022 skin
    When the appearance menu is displayed
    Then the menu should show options for font size and width instead of the width toggle

Test Steps

Test Case 1: Verify Appearance Menu Shows Font Size and Width on Beta Sites

  1. Visit Commons Beta and Wikivoyage Beta.
  2. Open the appearance menu.
  3. AC1: Confirm that the menu shows options for font size and width.

Communication criteria - does this need an announcement or discussion?

no

Rollback plan

  • We'll deploy via configuration change earlier in the week (Monday 9th September) to mitigate risk of a roll back.
  • In event of a problem, we can safely revert the patch, however with inconsistent UI (some will have font size control and some won't)

QA Results - Beta

ACStatusDetails
1✅T367591#10128048

QA Results - PROD

ACStatusDetails
1✅T367591#10180269

Event Timeline

Jdlrobson changed the task status from Open to Stalled.Jun 18 2024, 4:09 PM
Jdlrobson subscribed.

It is only deployed to Wikipedias right now. We would need to deploy everywhere to be able to remove it. Or am I misunderstanding?
e.g. https://pl.wikisource.org/wiki/Wiki%C5%BAr%C3%B3d%C5%82a:Strona_g%C5%82%C3%B3wna

Change #1058249 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/Vector@master] Remove old limited width toggle

https://gerrit.wikimedia.org/r/1058249

We decided to block this on the roll out.

On Monday, we should discuss whether to make this roll out happen via train this sprint or via deployment (and move to next sprint)

Given the above doesn't seem to have happened, I am assuming this should be moved to next sprint.

Update: Waiting on Szymon green light per Olga's updates

Change #1058249 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove old limited width toggle

https://gerrit.wikimedia.org/r/1058249

Per standup I merged this for next week's train so we can get more testing in the beta cluster. As it stands T367591 will now automatically happen on Thursday September 12th but we can check in on Monday about whether we are not ready and revert this if need be.

Change #1071043 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Drop unused code

https://gerrit.wikimedia.org/r/1071043

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Appearance Menu Shows Font Size and Width on Beta Sites

  1. Visit Commons Beta and Wikivoyage Beta.
  2. Open the appearance menu.
  3. ✅AC1: Confirm that the menu shows options for font size and width.

Not shown below, but this also functions correctly in wide width

Commons Beta

screenshot 51.png (2,051×932 px, 253 KB)

screenshot 50.png (2,046×932 px, 243 KB)

screenshot 52.png (2,049×932 px, 245 KB)

screenshot 53.png (2,049×932 px, 261 KB)

Wikivoyage Beta

screenshot 54.png (2,049×932 px, 425 KB)

screenshot 57.png (2,049×932 px, 489 KB)

screenshot 55.png (2,049×932 px, 413 KB)

screenshot 56.png (2,049×932 px, 497 KB)

Edtadros updated the task description. (Show Details)
Edtadros subscribed.

Change #1071043 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Drop unused code relating to old limited width toggle.

https://gerrit.wikimedia.org/r/1071043

This change rode the train this week and is now in production!

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS 15.0
Browser: Chrome 129
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Appearance Menu Shows Font Size and Width on PROD Sites

  1. Visit Commons and Wikivoyage.
  2. Open the appearance menu.
  3. ✅AC1: Confirm that the menu shows options for font size and width.

Commons

Logged-In side barLogged-In hiddenLogged-Out side barLogged-Out hidden
2024-09-26_08-15-02.png (1,597×619 px, 458 KB)
2024-09-26_08-16-01.png (1,611×558 px, 331 KB)
2024-09-26_08-16-29.png (1,573×519 px, 213 KB)
2024-09-26_08-16-48.png (1,594×557 px, 257 KB)

Wikivoyage

Logged-In side barLogged-In hiddenLogged-Out side barLogged-Out hidden
2024-09-26_08-17-03.png (1,586×585 px, 523 KB)
2024-09-26_08-17-17.png (1,590×538 px, 375 KB)
2024-09-26_08-17-34.png (1,601×465 px, 430 KB)
2024-09-26_08-17-48.png (1,589×441 px, 388 KB)