Disallow creating commit-based Herald rules
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Jun 16 2024, 10:48 AM

Description

Slightly better for performance; rarely used anyway.

First sort out T366578 though.

Related Objects
Search...

Status	Assigned	Task
Open	None	T108586 Herald rules causing delays to task edit saves - getting worse
Resolved	Aklapper	T367651 Disallow creating commit-based Herald rules
Resolved	He7d3r	T366578 Disable remaining commit-based Herald rules H49, H50, H51?

Event Timeline

diff --git a/src/applications/diffusion/herald/HeraldCommitAdapter.php b/src/applications/diffusion/herald/HeraldCommitAdapter.php
index 0ec9de7e87..2359e8bef5 100644
--- a/src/applications/diffusion/herald/HeraldCommitAdapter.php
+++ b/src/applications/diffusion/herald/HeraldCommitAdapter.php
@@ -86,14 +86,15 @@ final class HeraldCommitAdapter
   }
 
   public function supportsRuleType($rule_type) {
-    switch ($rule_type) {
-      case HeraldRuleTypeConfig::RULE_TYPE_GLOBAL:
-      case HeraldRuleTypeConfig::RULE_TYPE_PERSONAL:
-      case HeraldRuleTypeConfig::RULE_TYPE_OBJECT:
-        return true;
-      default:
+// WMF T367651 - Disallow commit-based Herald rules (performance)
+//    switch ($rule_type) {
+//      case HeraldRuleTypeConfig::RULE_TYPE_GLOBAL:
+//      case HeraldRuleTypeConfig::RULE_TYPE_PERSONAL:
+//      case HeraldRuleTypeConfig::RULE_TYPE_OBJECT:
+//        return true;
+//      default:
         return false;
-    }
+//    }
   }
 
   public function canTriggerOnObject($object) {
diff --git a/src/applications/diffusion/herald/HeraldPreCommitAdapter.php b/src/applications/diffusion/herald/HeraldPreCommitAdapter.php
index 4707545e9d..c13dd55d65 100644
--- a/src/applications/diffusion/herald/HeraldPreCommitAdapter.php
+++ b/src/applications/diffusion/herald/HeraldPreCommitAdapter.php
@@ -52,14 +52,15 @@ abstract class HeraldPreCommitAdapter extends HeraldAdapter {
   }
 
   public function supportsRuleType($rule_type) {
-    switch ($rule_type) {
-      case HeraldRuleTypeConfig::RULE_TYPE_GLOBAL:
-      case HeraldRuleTypeConfig::RULE_TYPE_OBJECT:
-      case HeraldRuleTypeConfig::RULE_TYPE_PERSONAL:
-        return true;
-      default:
+// WMF T367651 - Disallow commit-based Herald rules (performance)
+//    switch ($rule_type) {
+//      case HeraldRuleTypeConfig::RULE_TYPE_GLOBAL:
+//      case HeraldRuleTypeConfig::RULE_TYPE_OBJECT:
+//      case HeraldRuleTypeConfig::RULE_TYPE_PERSONAL:
+//        return true;
+//      default:
         return false;
-    }
+//    }
   }