Page MenuHomePhabricator
Create Task
Maniphest T367683

Remove the spamblacklistlog right from the edit filter helper group (enwiki) and wikidata-staff (wikidatawiki)
Closed, ResolvedPublic
Actions

Description

Since only logged-in users are allowed to see the spam block list log (per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SpamBlacklist/+/405670/), and with the edit filter helper permission (abusefilter-helper) on the English Wikipedia already containing this right, then I believe it should be removed from the EFH permission as, mentioned before, all logged-in users can see the spamblacklist log.

EDIT:
This flag is also present on wikidatawiki. The project was notified on 21 June and there are also two comments supporting the change.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Removing 'spamblacklistlog' right from usergroupsoperations/mediawiki-configmaster+0 -2
enwiki: remove spamblacklistlog from abusefilter-helperoperations/mediawiki-configmaster+0 -1
Customize query in gerrit

Event Timeline

codenamenoreste created this task.Jun 17 2024, 6:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2024, 6:29 AM
JJMC89 edited projects, added Wikimedia-Site-requests; removed MediaWiki-User-management.Jun 17 2024, 6:58 AM
JJMC89 subscribed.
Novem_Linguae subscribed.Jun 17 2024, 7:27 AM
Novem_Linguae added a comment.Jun 17 2024, 7:37 AM

I suppose this makes sense. If I'm reading this right, this will have zero effect on the end user, while making https://en.wikipedia.org/wiki/Special:ListGroupRights a tiny bit easier to read. There is no case I can think of where an EFH would not also be a user.

Might need to drop a note at WT:EFH and WT:SBL as a formality.

DreamRimmer subscribed.Jun 18 2024, 2:09 PM
Superpes15 claimed this task.Jun 19 2024, 8:10 PM
Superpes15 subscribed.

Yep! It's redundant :) Please let me know when you have left a note on enwiki!

codenamenoreste added a comment.Jun 24 2024, 4:25 AM

I left a note on WP:VPT about this on https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Ongoing_Phabricator_request_to_remove_the_spamblacklistlog_right_from_the_edit_filter_helper_right rather than WT:EFH since the latter has minimal participation.

Novem_Linguae added a comment.Jun 24 2024, 4:29 AM

Edit filter helpers are more likely to have EFH watchlisted than VPT. I've gone ahead and dropped notices at EFH and SBL.

Kind of just a formality. This change shouldn't affect anything except the code.

gerritbot added a comment.Jun 24 2024, 4:53 AM

Change #1048896 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[operations/mediawiki-config@master] enwiki: remove spamblacklistlog from abusefilter-helper

https://gerrit.wikimedia.org/r/1048896

gerritbot added a project: Patch-For-Review.Jun 24 2024, 4:53 AM
gerritbot added a comment.Jun 25 2024, 10:01 AM

Change #1049500 had a related patch set uploaded (by Superpes15; author: Superpes15):

[operations/mediawiki-config@master] Removing 'spamblacklistlog' rights to usergroups

https://gerrit.wikimedia.org/r/1049500

Superpes15 renamed this task from Remove the spamblacklistlog right from the edit filter helper group (enwiki) to Remove the spamblacklistlog right from the edit filter helper group.Jun 25 2024, 10:04 AM
Superpes15 updated the task description. (Show Details)
Superpes15 renamed this task from Remove the spamblacklistlog right from the edit filter helper group to Remove the spamblacklistlog right from the edit filter helper group (enwiki) and wikidata-staff (wikidatawiki).Jun 25 2024, 10:07 AM
gerritbot added a comment.Jun 25 2024, 1:34 PM

Change #1048896 abandoned by Novem Linguae:

[operations/mediawiki-config@master] enwiki: remove spamblacklistlog from abusefilter-helper

Reason:

duplicate of https://gerrit.wikimedia.org/r/1049500

https://gerrit.wikimedia.org/r/1048896

Xaosflux subscribed.Jun 26 2024, 3:35 PM
Xaosflux triaged this task as Low priority.Jun 26 2024, 3:38 PM

sure, seems to be a zero actual impact. Also seems to be makework cleanup, but whatever; if one or both of these projects want to remove this from the primary group they can pick where it should end up at the same time in the future

Superpes15 raised the priority of this task from Low to Medium.Jun 26 2024, 4:01 PM

Hi @Xaosflux, please note that the priority should be changed by whoever works on a task or based on the team/project, I already created a patch, which is ready, and I'll schedule it for deployment during the next week, so we can consider it as a normal priority (I'm just waiting for some days after the notification, and I usually don't use prioritization)! Thanks :P

Superpes15 raised the priority of this task from Medium to Needs Triage.Jun 26 2024, 4:02 PM
gerritbot added a comment.Aug 26 2024, 10:07 PM

Change #1049500 merged by jenkins-bot:

[operations/mediawiki-config@master] Removing 'spamblacklistlog' right from usergroups

https://gerrit.wikimedia.org/r/1049500

Stashbot added a comment.Aug 26 2024, 10:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-26T22:10:34Z] <zabe@deploy1003> Started scap sync-world: Backport for [[gerrit:1049500|Removing 'spamblacklistlog' right from usergroups (T367683)]]

Stashbot added a comment.Aug 26 2024, 10:12 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-26T22:12:31Z] <zabe@deploy1003> superpes, zabe: Backport for [[gerrit:1049500|Removing 'spamblacklistlog' right from usergroups (T367683)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Pppery closed this task as Resolved.Aug 26 2024, 10:14 PM
Stashbot added a comment.Aug 26 2024, 10:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-08-26T22:17:32Z] <zabe@deploy1003> Finished scap sync-world: Backport for [[gerrit:1049500|Removing 'spamblacklistlog' right from usergroups (T367683)]] (duration: 06m 58s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits