See milestone for details.
Description
Details
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| update submodules for 2024-06-18 release | repos/phabricator/deployment!45 | brennen | work/2024-06-18-release | wmf/stable |
Related Objects
- Mentioned In
- T364839: Investigate / remove custom downstream changes to PhabricatorClientRateLimit.php
rPHDEPebe3a947ad22: update submodules for 2024-06-18 release - Mentioned Here
- T364839: Investigate / remove custom downstream changes to PhabricatorClientRateLimit.php
rPHABad36a4ded8b3: Revert custom changes to PhabricatorClientRateLimit.php
Event Timeline
brennen opened https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/45
Draft: update submodules for 2024-06-18 release
brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/45
update submodules for 2024-06-18 release
Icinga downtime and Alertmanager silence (ID=434fb169-ea49-4b50-99c6-92fe8b7cc86e) set by jelto@cumin1002 for 0:30:00 on 1 host(s) and their services with reason: Phabricator/Phorge update
phab1004.eqiad.wmnet
Icinga downtime and Alertmanager silence (ID=f4fe9445-4599-4964-a4f6-56cd41103592) set by jelto@cumin1002 for 0:30:00 on 1 host(s) and their services with reason: Phabricator/Phorge update
phab2002.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2024-06-18T15:04:28Z] <brennen@deploy1002> Started deploy [phabricator/deployment@ebe3a94]: deploy phab2002 for T367775
Mentioned in SAL (#wikimedia-operations) [2024-06-18T15:05:05Z] <brennen@deploy1002> Finished deploy [phabricator/deployment@ebe3a94]: deploy phab2002 for T367775 (duration: 00m 36s)
Mentioned in SAL (#wikimedia-operations) [2024-06-18T15:05:28Z] <brennen@deploy1002> Started deploy [phabricator/deployment@ebe3a94]: deploy phab1004 for T367775
Mentioned in SAL (#wikimedia-operations) [2024-06-18T15:07:41Z] <brennen@deploy1002> Finished deploy [phabricator/deployment@ef680d8]: revert phab1004 after breakage for T367775 (duration: 00m 15s)
Today's attempt to deploy broke Phabricator, displaying https://phabricator.wikimedia.org/source/phabricator/browse/wmf%252Fstable/support/startup/PhabricatorClientRateLimit.php$60-63 for everyone.
Thus https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/52 / T364839: Investigate / remove custom downstream changes to PhabricatorClientRateLimit.php / https://phabricator.wikimedia.org/rPHABad36a4ded8b3dd6bde81f76974fd7567e07fc202 is the culprit.