Page MenuHomePhabricator

Javascript error appears in console when copying permalinks
Closed, DuplicatePublic

Description

I see the event emitted on de.wiki and en-beta.

Screenshot 2024-06-04 at 20.05.43.png (2,590×992 px, 343 KB)

However, I get a console error like like TypeError: Cannot read properties of undefined (reading 'length') on de.wiki and hr.wiki. This doesn't look like a bug introduced in the code changes for this ticket.

Screenshot 2024-06-04 at 20.03.28.png (3,440×1,210 px, 399 KB)

Event Timeline

The error in F54942927 boils down to copyLink being passed an incorrect argument -- link is undefined. Suggests that there's a .ext-discussiontools-init-timestamplink link in there somewhere which doesn't have an href, which is peculiar.

(Could easily put up guardrails against the situation, but it'd be good to make sure we're not generating such a malformed link...)